msvs_gyp_wrapper.py - Issue 10234088: Use GYP to generate MSVS project files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: msvs_gyp_wrapper.py

Issue 10234088: Use GYP to generate MSVS project files (Closed)

Left Patch Set: Tests passing now Created April 24, 2013, 10:37 a.m.

Right Patch Set: Moved project files to build/ Created April 24, 2013, 1:57 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
	1 #!/usr/bin/env python

	2 # coding: utf-8

	3

	4 import os, sys

	5 base_dir = os.path.abspath(os.path.dirname(__file__))

	6

	7 sys.path.append(os.path.join(base_dir, 'third_party', 'gyp', 'pylib'))

	8 import gyp

	9 import gyp.generator.msvs

	10

	11 orig_fix_path = gyp.generator.msvs._FixPath

	12

	13 def _FixPath(path):

	14 if path == 'CORE' or path == 'EXPERIMENTAL' or path == 'off':

	15 # Don't touch js2c parameters

	16 return path
	Eric 2013/04/24 14:21:56 This may well cause a different kind of failure ov This may well cause a different kind of failure over time if directories do need to get changed. No worries, though. I understand this is just an expedient for the moment. Wladimir Palant 2013/04/24 14:51:05 This is pretty safe actually - I doubt that we wil This is pretty safe actually - I doubt that we will ever see directories with such names. I fact, I tried a more generic change first: assume that anything without dots and slashes isn't a path. That works fine for V8 but our codebase unfortunately uses 'include' and 'googletest' as include paths. Not sure whether we can still suggest a better solution to the gyp developers (like checking whether the paths actually exist) but getting js2c.py fixed looks like a more promising approach right now.
	17 return orig_fix_path(path)

	18 gyp.generator.msvs._FixPath = _FixPath

	19

	20 if __name__ == '__main__':

	21 gyp.main(sys.argv[1:])

LEFT	RIGHT