Use GYP to generate MSVS project files

third_party/googletest.gyp

Index: third_party/googletest.gyp
===================================================================
--- a/third_party/googletest.gyp
+++ b/third_party/googletest.gyp
@@ -1,9 +1,16 @@
 {

[Eric, 2013/04/23 17:12:17]

If we're going to go down the path of altering our third-party dependencies to
fit, we certainly can.

It would seem, however, that we could get the same effect with an 'include' of
this file and setting configurations outside.

Don't take this observation as a strong argument against this change.

[Wladimir Palant, 2013/04/24 06:01:34]

This file isn't part of googletest, that's why it is outside the googletest
repository. Out of the box googletest uses make or CMake to compile - the gyp
file is ours, as are its shortcomings.

[Eric, 2013/04/24 13:09:44]

Ah. Didn't realize that.

Never mind.

+  'configurations': {
+    'Debug': {
+      'defines': [ 'DEBUG' ],
+    },
+    'Release': {
+    },
+  },
   'targets': [{
     'target_name': 'googletest',
     'type': '<(library)',
     'sources': [
       'googletest/src/gtest-death-test.cc',
       'googletest/src/gtest-filepath.cc',
       'googletest/src/gtest-port.cc',
       'googletest/src/gtest-printers.cc',
@@ -11,17 +18,23 @@
       'googletest/src/gtest-typed-test.cc',
       'googletest/src/gtest.cc'
     ],
     'direct_dependent_settings': {
       'include_dirs': [
         'googletest',
         'googletest/include'
       ]

[Eric, 2013/04/23 17:12:17]

Does this work to compile our tests correctly? (as opposed to this library
only). I don't recall if the header that fails is required to compile tests or
not.

Regardless, moving this condition into direct_dependent_settings would ensure
that tests get compiled with the definition.

[Wladimir Palant, 2013/04/24 06:01:34]

No, it doesn't - at least not on Windows. I'm still in the process of fixing
that file, the include directories need to be specified for both targets. As I
mentioned, this is work in progress.

-    }
+    },
+    'conditions': [[
+      'OS=="win"',
+      {
+        'defines': [ '_VARIADIC_MAX=10' ],
+      }
+    ]],
   },
   {
     'target_name': 'googletest_main',
     'type': '<(library)',
     'sources': ['googletest/src/gtest_main.cc'],
     'dependencies': ['googletest'],
     'export_dependent_settings': ['googletest']
   }]