include/AdblockPlus/FilterEngine.h - Issue 10236010: Always work with pointers to filters and subscriptions, drop the references for API consistency

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 10236010: Always work with pointers to filters and subscriptions, drop the references for API consistency (Closed)

Patch Set: Created April 11, 2013, 7:24 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include/AdblockPlus/FilterEngine.h

===================================================================

--- a/include/AdblockPlus/FilterEngine.h

+++ b/include/AdblockPlus/FilterEngine.h

@@ -92,18 +92,18 @@ namespace AdblockPlus

typedef void (*SubscriptionsCallback)(const std::vector<SubscriptionPtr>&);

class FilterEngine

{

friend class Filter;

friend class Subscription;

public:

explicit FilterEngine(JsEngine& jsEngine);

- Filter& GetFilter(const std::string& text);

- Subscription& GetSubscription(const std::string& url);

+ FilterPtr GetFilter(const std::string& text);

+ SubscriptionPtr GetSubscription(const std::string& url);

const std::vector<FilterPtr>& GetListedFilters() const;

const std::vector<SubscriptionPtr>& GetListedSubscriptions() const;

void FetchAvailableSubscriptions(SubscriptionsCallback callback);

FilterPtr Matches(const std::string& url,

const std::string& contentType,

const std::string& documentUrl);

std::vector<std::string> GetElementHidingSelectors(const std::string& domain) const;

« no previous file with comments | « no previous file | shell/src/FiltersCommand.cpp » ('j') | no next file with comments »