Implemented curl support for web requests

test/WebRequest.cpp

 #include <sstream>
 #include <AdblockPlus.h>
 #include <gtest/gtest.h>
 
 #include "../src/Thread.h"
 
 class TestWebRequest : public AdblockPlus::WebRequest
 {
 public:
-  AdblockPlus::ServerResponse GET(const std::string& url, const AdblockPlus::HeadersList& requestHeaders) const
+  AdblockPlus::ServerResponse GET(const std::string& url, const AdblockPlus::HeaderList& requestHeaders) const
   {
     AdblockPlus::Sleep(50);
 
     AdblockPlus::ServerResponse result;
     result.status = NS_OK;
     result.responseStatus = 123;
     result.responseHeaders.push_back(std::pair<std::string, std::string>("Foo", "Bar"));
     result.responseText = url + "\n" + requestHeaders[0].first + "\n" + requestHeaders[0].second;
     return result;
   }
 };
 
 std::string ToString(unsigned int i)
 {
   std::stringstream stream;
   stream << i;
   return stream.str();
 }
 
 TEST(WebRequestTest, BadCall)
 {
   AdblockPlus::JsEngine jsEngine(0, 0, 0);
-  ASSERT_ANY_THROW(jsEngine.Evaluate("_request.GET()"));
-  ASSERT_ANY_THROW(jsEngine.Evaluate("_request.GET('', {}, function(){})"));
-  ASSERT_ANY_THROW(jsEngine.Evaluate("_request.GET({toString: false}, {}, function(){})"));
-  ASSERT_ANY_THROW(jsEngine.Evaluate("_request.GET('http://example.com/', null, function(){})"));
-  ASSERT_ANY_THROW(jsEngine.Evaluate("_request.GET('http://example.com/', {}, null)"));
-  ASSERT_ANY_THROW(jsEngine.Evaluate("_request.GET('http://example.com/', {}, function(){}, 0)"));
+  ASSERT_ANY_THROW(jsEngine.Evaluate("_webRequest.GET()"));
+  ASSERT_ANY_THROW(jsEngine.Evaluate("_webRequest.GET('', {}, function(){})"));
+  ASSERT_ANY_THROW(jsEngine.Evaluate("_webRequest.GET({toString: false}, {}, function(){})"));
+  ASSERT_ANY_THROW(jsEngine.Evaluate("_webRequest.GET('http://example.com/', null, function(){})"));
+  ASSERT_ANY_THROW(jsEngine.Evaluate("_webRequest.GET('http://example.com/', {}, null)"));
+  ASSERT_ANY_THROW(jsEngine.Evaluate("_webRequest.GET('http://example.com/', {}, function(){}, 0)"));
 }
 
 TEST(WebRequestTest, TestWebRequest)
 {
   TestWebRequest webRequest;
   AdblockPlus::JsEngine jsEngine(0, &webRequest, 0);
-  jsEngine.Evaluate("_request.GET('http://example.com/', {X: 'Y'}, function(result) {foo = result;} )");
+  jsEngine.Evaluate("_webRequest.GET('http://example.com/', {X: 'Y'}, function(result) {foo = result;} )");
   ASSERT_EQ("undefined", jsEngine.Evaluate("typeof foo"));
   AdblockPlus::Sleep(200);
-  ASSERT_EQ(ToString(NS_OK), jsEngine.Evaluate("foo.status"));
+  ASSERT_EQ(ToString(AdblockPlus::WebRequest::NS_OK), jsEngine.Evaluate("foo.status"));
   ASSERT_EQ("123", jsEngine.Evaluate("foo.responseStatus"));
   ASSERT_EQ("http://example.com/\nX\nY", jsEngine.Evaluate("foo.responseText"));
   ASSERT_EQ("{\"Foo\":\"Bar\"}", jsEngine.Evaluate("JSON.stringify(foo.responseHeaders)"));
 }
 
 #if defined(HAVE_CURL)
 TEST(WebRequestTest, RealWebRequest)
 {
   AdblockPlus::DefaultWebRequest webRequest;
   AdblockPlus::JsEngine jsEngine(0, &webRequest, 0);
 
   // This URL should redirect to easylist-downloads.adblockplus.org and we
   // should get the actual filter list back.
-  jsEngine.Evaluate("_request.GET('https://easylist.adblockplus.org/easylist.txt', {}, function(result) {foo = result;} )");
+  jsEngine.Evaluate("_webRequest.GET('https://easylist.adblockplus.org/easylist.txt', {}, function(result) {foo = result;} )");
   do
   {
     AdblockPlus::Sleep(200);
   } while (jsEngine.Evaluate("typeof foo") == "undefined");
-  ASSERT_EQ(ToString(NS_OK), jsEngine.Evaluate("foo.status"));
+  ASSERT_EQ(ToString(AdblockPlus::WebRequest::NS_OK), jsEngine.Evaluate("foo.status"));
   ASSERT_EQ("200", jsEngine.Evaluate("foo.responseStatus"));
   ASSERT_EQ("[Adblock Plus ", jsEngine.Evaluate("foo.responseText.substr(0, 14)"));
   ASSERT_EQ("text/plain", jsEngine.Evaluate("foo.responseHeaders['content-type'].substr(0, 10)"));

[Oleksandr, 2013/04/16 12:02:01]

Do we care if the header is "content-type" or "Content-Type"? Same for all other
headers.

[Felix Dahlke, 2013/04/16 12:21:09]

HTTP headers are case insensitive, so we can easily make sure they're lowercase.
libcurl seems to do so, but I couldn't see that being documented actually, it's
probably better to make WebRequest convert all header names to lower case.

[Wladimir Palant, 2013/04/16 13:30:32]

I don't think that curl lowercases header names - but DefaultWebRequestCurl.cpp
does:

  std::transform(name.begin(), name.end(), name.begin(), ::tolower);

XMLHttpRequest.getResponseHeader() also lowercases the headers when looking them
up, this makes sure that they are actually treated as case-insensitive.

[Felix Dahlke, 2013/04/16 14:51:37]

Hm, seems I missed that then.
It only lower cases the header name in the argument though. I think it's
easiest/safest if we just lower case them in XMLHttpRequest or
WebRequestJsObject, then it won't matter what the implementation does.

[Wladimir Palant, 2013/04/17 06:56:20]

I don't quite get this suggestion, WebRequestJsObject works with plain JS
objects for headers - it cannot impose any semantics on them (and it's an
internal implementation detail anyway, real code should always use
XMLHttpRequest). XMLHttpRequest on the other hand can ensure that headers are
treated in a case-insensitive way (per spec).

   ASSERT_EQ("undefined", jsEngine.Evaluate("typeof foo.responseHeaders['location']"));
 }
 #else
 TEST(WebRequestTest, DummyWebRequest)
 {
   AdblockPlus::DefaultWebRequest webRequest;
   AdblockPlus::JsEngine jsEngine(0, &webRequest, 0);
-  jsEngine.Evaluate("_request.GET('https://easylist.adblockplus.org/easylist.txt', {}, function(result) {foo = result;} )");
+  jsEngine.Evaluate("_webRequest.GET('https://easylist.adblockplus.org/easylist.txt', {}, function(result) {foo = result;} )");
   do
   {
     AdblockPlus::Sleep(200);
   } while (jsEngine.Evaluate("typeof foo") == "undefined");
-  ASSERT_EQ(ToString(NS_ERROR_FAILURE), jsEngine.Evaluate("foo.status"));
+  ASSERT_EQ(ToString(AdblockPlus::WebRequest::NS_ERROR_FAILURE), jsEngine.Evaluate("foo.status"));
   ASSERT_EQ("0", jsEngine.Evaluate("foo.responseStatus"));
   ASSERT_EQ("", jsEngine.Evaluate("foo.responseText"));
   ASSERT_EQ("{}", jsEngine.Evaluate("JSON.stringify(foo.responseHeaders)"));
 }
 #endif