include/AdblockPlus/JsValue.h - Issue 10254076: API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: include/AdblockPlus/JsValue.h

Issue 10254076: API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue (Closed)

Left Patch Set: Created April 26, 2013, 11:41 a.m.

Right Patch Set: Slightly better Filter/Subscription constructors Created April 26, 2013, 11:51 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #ifndef ADBLOCKPLUS_JS_VALUE_H	1 #ifndef ADBLOCKPLUS_JS_VALUE_H

2 #define ADBLOCKPLUS_JS_VALUE_H	2 #define ADBLOCKPLUS_JS_VALUE_H

3	3

4 #include <string>	4 #include <string>

5 #include <vector>	5 #include <vector>

6 #include <v8.h>	6 #include <v8.h>

7 #include "tr1_memory.h"	7 #include "tr1_memory.h"

8	8

9 namespace AdblockPlus	9 namespace AdblockPlus

10 {	10 {

11 class JsValue;	11 class JsValue;

12 class JsEngine;	12 class JsEngine;

13	13

14 typedef std::tr1::shared_ptr<JsValue> JsValuePtr;	14 typedef std::tr1::shared_ptr<JsValue> JsValuePtr;

15 typedef std::vector<AdblockPlus::JsValuePtr> JsValueList;	15 typedef std::vector<AdblockPlus::JsValuePtr> JsValueList;

16	16

17 // Forward declaration to avoid including JsEngine.h	17 // Forward declaration to avoid including JsEngine.h

18 typedef std::tr1::shared_ptr<JsEngine> JsEnginePtr;	18 typedef std::tr1::shared_ptr<JsEngine> JsEnginePtr;

19	19

20 class JsValue	20 class JsValue

21 {	21 {

22 friend class JsEngine;	22 friend class JsEngine;

23 friend class Filter;

24 friend class Subscription;

25 public:	23 public:

	24 JsValue(JsValuePtr value);

26 virtual ~JsValue();	25 virtual ~JsValue();

27	26

28 bool IsUndefined() const;	27 bool IsUndefined() const;

29 bool IsNull() const;	28 bool IsNull() const;

30 bool IsString() const;	29 bool IsString() const;

31 bool IsNumber() const;	30 bool IsNumber() const;

32 bool IsBool() const;	31 bool IsBool() const;

33 bool IsObject() const;	32 bool IsObject() const;

34 bool IsArray() const;	33 bool IsArray() const;

35 bool IsFunction() const;	34 bool IsFunction() const;

(...skipping 21 matching lines...) Expand all Loading...
57 protected:	56 protected:

58 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);	57 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);

59 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);	58 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);

60	59

61 JsEnginePtr jsEngine;	60 JsEnginePtr jsEngine;

62 v8::Persistent<v8::Value> value;	61 v8::Persistent<v8::Value> value;

63 };	62 };

64 }	63 }

65	64

66 #endif	65 #endif

LEFT	RIGHT