shell/src/SubscriptionsCommand.cpp - Issue 10254076: API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: shell/src/SubscriptionsCommand.cpp

Issue 10254076: API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue (Closed)

Patch Set: Created April 26, 2013, 11:41 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: shell/src/SubscriptionsCommand.cpp

===================================================================

--- a/shell/src/SubscriptionsCommand.cpp

+++ b/shell/src/SubscriptionsCommand.cpp

@@ -7,21 +7,22 @@ namespace

{

typedef std::vector<AdblockPlus::SubscriptionPtr> SubscriptionList;

void ShowSubscriptionList(const SubscriptionList& subscriptions)

{

for (SubscriptionList::const_iterator it = subscriptions.begin();

it != subscriptions.end(); it++)

{

- std::cout << (*it)->GetProperty("title", "(no title)") << " - " << (*it)->GetProperty("url", "");

- if ((*it)->GetProperty("author", "") != "")

- std::cout << " - " << (*it)->GetProperty("author", "");

- if ((*it)->GetProperty("specialization", "") != "")

- std::cout << " - " << (*it)->GetProperty("specialization", "");

+ std::cout << (*it)->GetProperty("title")->AsString();

+ std::cout << " - " << (*it)->GetProperty("url")->AsString();

+ if (!(*it)->GetProperty("author")->IsUndefined())

+ std::cout << " - " << (*it)->GetProperty("author")->AsString();

+ if (!(*it)->GetProperty("specialization")->IsUndefined())

+ std::cout << " - " << (*it)->GetProperty("specialization")->AsString();

std::cout << std::endl;

}

SubscriptionsCommand::SubscriptionsCommand(

AdblockPlus::FilterEngine& filterEngine)

: Command("subscriptions"), filterEngine(filterEngine)

« no previous file with comments | « shell/src/MatchesCommand.cpp ('k') | src/FilterEngine.cpp » ('j') | no next file with comments »