include/AdblockPlus/WebRequest.h - Issue 10259001: XMLHttpRequest API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: include/AdblockPlus/WebRequest.h

Issue 10259001: XMLHttpRequest API (Closed)

Patch Set: Created April 10, 2013, 3:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #ifndef ADBLOCKPLUS_WEB_REQUEST_H

	2 #define ADBLOCKPLUS_WEB_REQUEST_H
	Felix Dahlke 2013/04/11 09:33:42 We usually have ADBLOCK_PLUS (with an underscore) We usually have ADBLOCK_PLUS (with an underscore) as a prefix for include guards. Wladimir Palant 2013/04/11 16:32:33 You better check that again, all include files hav Show quoted text On 2013/04/11 09:33:42, Felix H. Dahlke wrote: > We usually have ADBLOCK_PLUS (with an underscore) as a prefix for include > guards. You better check that again, all include files have ADBLOCKPLUS as prefix. Felix Dahlke 2013/04/11 17:39:28 No, not really. Just the one in Thread.h for some Show quoted text On 2013/04/11 16:32:33, Wladimir Palant wrote: > On 2013/04/11 09:33:42, Felix H. Dahlke wrote: > > We usually have ADBLOCK_PLUS (with an underscore) as a prefix for include > > guards. > > You better check that again, all include files have ADBLOCKPLUS as prefix. No, not really. Just the one in Thread.h for some reason.
	3

	4 #include <string>

	5 #include <vector>

	6

	7 namespace AdblockPlus

	8 {

	9 typedef std::vector< std::pair<std::string, std::string> > HeadersList;
	Felix Dahlke 2013/04/11 09:33:42 We usually only have whitespace between >/< if it' We usually only have whitespace between >/< if it'd end up being >>/<< otherwise, i.e. not the one after the < here. Wladimir Palant 2013/04/11 16:32:33 I prefer proper grouping as done here. Seeing the Show quoted text On 2013/04/11 09:33:42, Felix H. Dahlke wrote: > We usually only have whitespace between >/< if it'd end up being >>/<< > otherwise, i.e. not the one after the < here. I prefer proper grouping as done here. Seeing the other style prevalent in the adblockplusie repository however I changed this regardless.
	10

	11 struct ServerResponse

	12 {

	13 HeadersList responseHeaders;
	Felix Dahlke 2013/04/11 09:33:42 How about "Headers" or "HeaderList"? I prefer the How about "Headers" or "HeaderList"? I prefer the former.
	14 int responseStatus;

	15 std::string responseText;

	16 };

	17

	18 class WebRequest

	19 {

	20 public:

	21 virtual ~WebRequest();

	22 virtual ServerResponse GET(const std::string& url, const HeadersList& reques tHeaders) const = 0;

	23 };

	24 }

	25

	26 #endif

OLD	NEW

« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | libadblockplus.gyp » ('j') | src/GlobalJsObject.cpp » ('J')