Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: src/WebRequest.cpp
Issue
10259001
:
XMLHttpRequest API (Closed)
Patch Set: Addressed review comments
Created April 11, 2013, 4:30 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed review comments
Right:
Patch Set 1: None
Patch Set 2: Addressed review comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
include/AdblockPlus.h
include/AdblockPlus/JsEngine.h
include/AdblockPlus/WebRequest.h
libadblockplus.gyp
shell/src/Main.cpp
src/GlobalJsObject.h
src/GlobalJsObject.cpp
src/JsEngine.cpp
src/WebRequest.cpp
src/WebRequestJsObject.h
src/WebRequestJsObject.cpp
test/ConsoleJsObject.cpp
test/FilterEngineStubs.cpp
test/GlobalJsObject.cpp
test/JsEngine.cpp
test/WebRequest.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« src/JsEngine.cpp
('k') |
src/WebRequestJsObject.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
#include <AdblockPlus/WebRequest.h>
2
3
AdblockPlus::WebRequest::~WebRequest()
4
{
5
}
OLD
NEW
« no previous file with comments
|
« src/JsEngine.cpp
('k') |
src/WebRequestJsObject.h »
('j') |
no next file with comments »
Edit Message
Issue 10259001: XMLHttpRequest API (Closed)
Created April 10, 2013, 3:19 p.m. by Wladimir Palant
Modified April 12, 2013, 11:17 a.m.
Reviewers: Felix Dahlke, Oleksandr
Base URL:
Comments: 14
This is Rietveld