Delta Between Two Patch Sets: src/GlobalJsObject.cpp
Issue 10296001:
Implement File API (Closed)
Left Patch Set: Don't pass a blog to _fileSystem.write
Created April 12, 2013, 12:10 p.m.
Right Patch Set: Addressed the new issues
Created April 16, 2013, 1:37 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« src/GlobalJsObject.h ('k')
|
src/JsEngine.cpp » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 #include <vector> | 1 #include <vector> |
| 2 #include <stdexcept> | 2 #include <stdexcept> |
| 3 | 3 |
| 4 #include "ConsoleJsObject.h" | 4 #include "ConsoleJsObject.h" |
| 5 #include "FileSystemJsObject.h" | 5 #include "FileSystemJsObject.h" |
| 6 #include "GlobalJsObject.h" | 6 #include "GlobalJsObject.h" |
| 7 #include "ConsoleJsObject.h" | 7 #include "ConsoleJsObject.h" |
| 8 #include "WebRequestJsObject.h" | 8 #include "WebRequestJsObject.h" |
| 9 #include "Thread.h" | 9 #include "Thread.h" |
| 10 | 10 |
| (...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 97 const v8::Handle<v8::ObjectTemplate> global = v8::ObjectTemplate::New(); | 97 const v8::Handle<v8::ObjectTemplate> global = v8::ObjectTemplate::New(); |
| 98 const v8::Handle<v8::FunctionTemplate> setTimeoutFunction = | 98 const v8::Handle<v8::FunctionTemplate> setTimeoutFunction = |
| 99 v8::FunctionTemplate::New(SetTimeoutCallback); | 99 v8::FunctionTemplate::New(SetTimeoutCallback); |
| 100 global->Set(v8::String::New("setTimeout"), setTimeoutFunction); | 100 global->Set(v8::String::New("setTimeout"), setTimeoutFunction); |
| 101 const v8::Handle<v8::ObjectTemplate> fileSystemObject = | 101 const v8::Handle<v8::ObjectTemplate> fileSystemObject = |
| 102 FileSystemJsObject::Create(fileSystem); | 102 FileSystemJsObject::Create(fileSystem); |
| 103 global->Set(v8::String::New("_fileSystem"), fileSystemObject); | 103 global->Set(v8::String::New("_fileSystem"), fileSystemObject); |
| 104 const v8::Handle<v8::ObjectTemplate> webRequestObject = | 104 const v8::Handle<v8::ObjectTemplate> webRequestObject = |
| 105 WebRequestJsObject::Create(webRequest); | 105 WebRequestJsObject::Create(webRequest); |
| 106 global->Set(v8::String::New("_webRequest"), webRequestObject); | 106 global->Set(v8::String::New("_webRequest"), webRequestObject); |
| 107 const v8::Handle<v8::ObjectTemplate> console = | 107 const v8::Handle<v8::ObjectTemplate> consoleObject = |
|
Wladimir Palant
2013/04/12 16:10:35
console => consoleObject for consistency?
Felix Dahlke
2013/04/15 03:43:34
Agreed.
| |
| 108 ConsoleJsObject::Create(errorCallback); | 108 ConsoleJsObject::Create(errorCallback); |
| 109 global->Set(v8::String::New("console"), console); | 109 global->Set(v8::String::New("console"), consoleObject); |
| 110 return handleScope.Close(global); | 110 return handleScope.Close(global); |
| 111 } | 111 } |
| LEFT | RIGHT |
« src/GlobalJsObject.h ('k')
|
src/JsEngine.cpp » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
