include/AdblockPlus/JsEngine.h - Issue 10296001: Implement File API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 10296001: Implement File API (Closed)

Patch Set: Address issues Created April 15, 2013, 1:42 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include/AdblockPlus/JsEngine.h

===================================================================

--- a/include/AdblockPlus/JsEngine.h

+++ b/include/AdblockPlus/JsEngine.h

@@ -7,9 +7,9 @@

namespace AdblockPlus

{

+ class FileSystem;

+ class WebRequest;

class ErrorCallback;

- class FileReader;

- class WebRequest;

class JsError : public std::runtime_error

{

@@ -21,7 +21,7 @@

class JsEngine

{

public:

- JsEngine(const FileReader* const fileReader,

+ JsEngine(FileSystem* const fileReader,

WebRequest* const webRequest,

ErrorCallback* const errorCallback);

std::string Evaluate(const std::string& source,

@@ -30,7 +30,7 @@

void Gc();

private:

- const FileReader* const fileReader;

+ const FileSystem* const fileSystem;

v8::Persistent<v8::Context> context;

};

}