include/AdblockPlus/ErrorCallback.h - Issue 10310030: Convert references to FileSystem & Co. into shared pointers (avoid use after free)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: include/AdblockPlus/ErrorCallback.h

Issue 10310030: Convert references to FileSystem & Co. into shared pointers (avoid use after free) (Closed)

Patch Set: Created April 18, 2013, 11:59 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #ifndef ADBLOCKPLUS_ERROR_CALLBACK_H	1 #ifndef ADBLOCKPLUS_ERROR_CALLBACK_H

2 #define ADBLOCKPLUS_ERROR_CALLBACK_H	2 #define ADBLOCKPLUS_ERROR_CALLBACK_H

3	3

4 #include <string>	4 #include <string>

5	5

	6 #include "tr1_memory.h"

	7

6 namespace AdblockPlus	8 namespace AdblockPlus

7 {	9 {

8 class ErrorCallback	10 class ErrorCallback

9 {	11 {

10 public:	12 public:

11 virtual ~ErrorCallback();	13 virtual ~ErrorCallback();

12 virtual void operator()(const std::string& message) = 0;	14 virtual void operator()(const std::string& message) = 0;

13 };	15 };

	16

	17 typedef std::tr1::shared_ptr<ErrorCallback> ErrorCallbackPtr;

14 }	18 }

15	19

16 #endif	20 #endif

OLD	NEW