include/AdblockPlus/FileSystem.h - Issue 10310030: Convert references to FileSystem & Co. into shared pointers (avoid use after free)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: include/AdblockPlus/FileSystem.h

Issue 10310030: Convert references to FileSystem & Co. into shared pointers (avoid use after free) (Closed)

Patch Set: Created April 18, 2013, 11:59 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #ifndef ADBLOCKPLUS_FILE_SYSTEM_H	1 #ifndef ADBLOCKPLUS_FILE_SYSTEM_H

2 #define ADBLOCKPLUS_FILE_SYSTEM_H	2 #define ADBLOCKPLUS_FILE_SYSTEM_H

3	3

4 #include <istream>	4 #include <istream>

5 #include <stdint.h>	5 #include <stdint.h>

6 #include <string>	6 #include <string>

7	7

8 #include "tr1_memory.h"	8 #include "tr1_memory.h"

9	9

10 namespace AdblockPlus	10 namespace AdblockPlus

(...skipping 12 matching lines...) Expand all Loading...
23 virtual ~FileSystem() {}	23 virtual ~FileSystem() {}

24 virtual std::tr1::shared_ptr<std::istream>	24 virtual std::tr1::shared_ptr<std::istream>

25 Read(const std::string& path) const = 0;	25 Read(const std::string& path) const = 0;

26 virtual void Write(const std::string& path,	26 virtual void Write(const std::string& path,

27 std::tr1::shared_ptr<std::ostream> data) = 0;	27 std::tr1::shared_ptr<std::ostream> data) = 0;

28 virtual void Move(const std::string& fromPath,	28 virtual void Move(const std::string& fromPath,

29 const std::string& toPath) = 0;	29 const std::string& toPath) = 0;

30 virtual void Remove(const std::string& path) = 0;	30 virtual void Remove(const std::string& path) = 0;

31 virtual StatResult Stat(const std::string& path) const = 0;	31 virtual StatResult Stat(const std::string& path) const = 0;

32 };	32 };

	33

	34 typedef std::tr1::shared_ptr<FileSystem> FileSystemPtr;

33 }	35 }

34	36

35 #endif	37 #endif

OLD	NEW