src/DefaultWebRequestCurl.cpp - Issue 10310030: Convert references to FileSystem & Co. into shared pointers (avoid use after free)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/DefaultWebRequestCurl.cpp

Issue 10310030: Convert references to FileSystem & Co. into shared pointers (avoid use after free) (Closed)

Patch Set: Created April 18, 2013, 11:59 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #include <sstream>	1 #include <sstream>

2 #include <cctype>	2 #include <cctype>

3 #include <algorithm>	3 #include <algorithm>

4 #include <curl/curl.h>	4 #include <curl/curl.h>

5 #include <AdblockPlus/WebRequest.h>	5 #include <AdblockPlus/DefaultWebRequest.h>

6	6

7 namespace	7 namespace

8 {	8 {

9 struct HeaderData	9 struct HeaderData

10 {	10 {

11 int status;	11 int status;

12 bool expectingStatus;	12 bool expectingStatus;

13 std::vector<std::string> headers;	13 std::vector<std::string> headers;

14	14

15 HeaderData()	15 HeaderData()

(...skipping 148 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
164 }	164 }

165 }	165 }

166 }	166 }

167	167

168 if (headerList)	168 if (headerList)

169 curl_slist_free_all(headerList);	169 curl_slist_free_all(headerList);

170 curl_easy_cleanup(curl);	170 curl_easy_cleanup(curl);

171 }	171 }

172 return result;	172 return result;

173 }	173 }

OLD	NEW