File system path resolving

src/DefaultWebRequestWinInet.cpp

 #include "AdblockPlus/DefaultWebRequest.h"
 #include "WinInetErrorCodes.h"
 #include <algorithm>
 #include <Windows.h>
 #include <winhttp.h>
 #include <Shlwapi.h>
 
 #include "Utils.h"
 
 class WinHttpHandle
@@ skipping 163 matching lines @@
 {
   AdblockPlus::ServerResponse result;
   result.status = NS_ERROR_FAILURE;
   result.responseStatus = 0;
 
   HRESULT hr;
   BOOL res;
 
   std::wstring canonizedUrl = Utils::CanonizeUrl(Utils::ToUTF16String(url, url.length()));
 
-  std::string headersString;
+  std::string headersString = "";

[Oleksandr, 2013/04/30 08:13:07]

This fixes an issue on XP. std::string's length is undefined otherwise.

[Felix Dahlke, 2013/04/30 09:14:52]

Worth a comment I think. Or is this not the only place where we have that fix?

   for (int i = 0; i < requestHeaders.size(); i++)
   {
     headersString += requestHeaders[i].first + ": ";
     headersString += requestHeaders[i].second + ";";
   }
   std::wstring headers = Utils::ToUTF16String(headersString, headersString.length());
 
   LPSTR outBuffer;
   DWORD downloadSize, downloaded;
   WinHttpHandle hSession(0), hConnect(0), hRequest(0);
@@ skipping 117 matching lines @@
       if( WinHttpReadData(hRequest, (LPVOID)outBuffer, downloadSize, &downloaded))
       {
         result.responseText.append(outBuffer, downloaded);
       }
       // Free the memory allocated to the buffer.
       delete[] outBuffer;
     }
   } while (downloadSize > 0);
   return result;
 }