File system path resolving

include/AdblockPlus/FileSystem.h

-#ifndef ADBLOCKPLUS_FILE_SYSTEM_H
-#define ADBLOCKPLUS_FILE_SYSTEM_H
+#ifndef ADBLOCK_PLUS_FILE_SYSTEM_H
+#define ADBLOCK_PLUS_FILE_SYSTEM_H
 
 #include <istream>
 #include <stdint.h>
 #include <string>
 
 #include "tr1_memory.h"
 
 namespace AdblockPlus
 {
   class FileSystem
@@ skipping 10 matching lines @@
     virtual ~FileSystem() {}
     virtual std::tr1::shared_ptr<std::istream>
       Read(const std::string& path) const = 0;
     virtual void Write(const std::string& path,
                        std::tr1::shared_ptr<std::ostream> data) = 0;
     virtual void Move(const std::string& fromPath,
                       const std::string& toPath) = 0;
     virtual void Remove(const std::string& path) = 0;
     virtual StatResult Stat(const std::string& path) const = 0;
     virtual std::string Resolve(const std::string& path) const = 0;
-    virtual void SetBasePath(const std::string& path) = 0;

[Wladimir Palant, 2013/04/30 09:29:50]

This shouldn't be a method of the FileSystem interface, rather one of the
DefaultFileSystem class. Other FileSystem implementation can work differently,
e.g. with an implicit base path or no base path at all (like the
MockFileSystem).

-  protected:
-    std::string basePath;

[Felix Dahlke, 2013/04/30 09:14:52]

I think we should either not declare basePath here or provide an implementation
of SetBasePath that sets it. I'm voting for the former.

   };
 
   typedef std::tr1::shared_ptr<FileSystem> FileSystemPtr;
 }
 
 #endif