File system path resolving

test/FileSystemJsObject.cpp

 #include "BaseJsTest.h"
 #include "../src/Thread.h"
 #include "../src/Utils.h"
 
 namespace
 {
   class MockFileSystem : public AdblockPlus::FileSystem
   {
   public:
     bool success;
@@ skipping 58 matching lines @@
       result.lastModified = statLastModified;
       return result;
     }
 
     std::string Resolve(const std::string& path) const
     {
       if (!success)
         throw std::runtime_error("Unable to stat " + path);
       return path;
     }
-
-    void SetBasePath(const std::string& path)
-    {
-      basePath = "";
-      return;

[Felix Dahlke, 2013/04/30 09:14:52]

I don't think this return is necessary.

-    }
-
   };
 
   void ReadFile(AdblockPlus::JsEnginePtr jsEngine, std::string& content,
                 std::string& error)
   {
     jsEngine->Evaluate("_fileSystem.read('', function(r) {result = r})");
     AdblockPlus::Sleep(50);
     content = jsEngine->Evaluate("result.content")->AsString();
     error = jsEngine->Evaluate("result.error")->AsString();
   }
@@ skipping 130 matching lines @@
   ASSERT_ANY_THROW(jsEngine->Evaluate("_fileSystem.stat('', '')"));
 }
 
 TEST_F(FileSystemJsObjectTest, StatError)
 {
   mockFileSystem->success = false;
   jsEngine->Evaluate("_fileSystem.stat('foo', function(r) {result = r})");
   AdblockPlus::Sleep(50);
   ASSERT_NE("", jsEngine->Evaluate("result.error")->AsString());
 }