Run a single FilterEngine instance in a separate process

AdblockPlusEngine/main.cpp

+#include <AdblockPlus.h>
+#include <iostream>
+#include <ShlObj.h>
+#include <sstream>
+#include <vector>
+#include <Windows.h>
+#include <Sddl.h>
+
+namespace
+{
+  const std::wstring pipeName = L"\\\\.\\pipe\\adblockplusengine";

[Wladimir Palant, 2013/05/23 14:25:01]

I realized that the pipe name should be user-specific - if a different user runs
Adblock Plus on the same machine, this user should have a different pipe. Please
use GetUserName() and incorporate it into the pipe name.

[Felix Dahlke, 2013/05/23 19:10:44]

Oh, you're right. Appended the user name. Considered using the SID instead, but
it's a hassle to get and I don't think using the name will cause problems here.

[Wladimir Palant, 2013/05/23 20:10:15]

Not sure whether the user name can be changed but definitely not when the user
is logged in - so not an issue.

+  const int bufferSize = 1024;
+  std::auto_ptr<AdblockPlus::FilterEngine> filterEngine;
+
+  class AutoHandle
+  {
+  public:
+    AutoHandle()
+    {
+    }
+
+    AutoHandle(HANDLE handle) : handle(handle)
+    {
+    }
+
+    ~AutoHandle()
+    {
+      CloseHandle(handle);
+    }
+
+    HANDLE get()
+    {
+      return handle;
+    }
+
+  private:
+    HANDLE handle;
+
+    AutoHandle(const AutoHandle& autoHandle);
+    AutoHandle& operator=(const AutoHandle& autoHandle);
+  };
+
+  void Log(const std::string& message)
+  {
+    // TODO: Log to a log file
+    MessageBoxA(0, ("AdblockPlusEngine: " + message).c_str(), "", MB_OK);
+  }
+
+  void LogLastError(const std::string& message)
+  {
+    std::stringstream stream;
+    stream << message << " (Error code: " << GetLastError() << ")";
+    Log(stream.str());
+  }
+
+  void LogException(const std::exception& exception)
+  {
+    Log(std::string("An exception occurred: ") + exception.what());
+  }
+
+  std::string MarshalStrings(const std::vector<std::string>& strings)
+  {
+    // TODO: This is some pretty hacky marshalling, replace it with something more robust
+    std::string marshalledStrings;
+    for (std::vector<std::string>::const_iterator it = strings.begin(); it != strings.end(); it++)
+      marshalledStrings += *it + ';';
+    return marshalledStrings;
+  }
+
+  std::vector<std::string> UnmarshalStrings(const std::string& message)
+  {
+    std::stringstream stream(message);
+    std::vector<std::string> strings;
+    std::string string;
+    while (std::getline(stream, string, ';'))
+        strings.push_back(string);
+    return strings;
+  }
+
+  std::string ToString(std::wstring value)
+  {
+    int size = WideCharToMultiByte(CP_UTF8, 0, value.c_str(), value.length(), 0, 0, 0, 0);

[Wladimir Palant, 2013/05/23 14:25:01]

Error case (size is 0 for a value with non-zero length) still isn't handled
here.

[Felix Dahlke, 2013/05/23 19:10:44]

It is, it returns an empty string. I thought it was better not to crash hard if
some conversion fails. The code I copied from libadblockplus handles the return
value of the first call, but not for the second, not exactly sure why.

[Wladimir Palant, 2013/05/23 20:10:15]

We should actually crash early here. While I cannot imagine what can cause a
conversion to UTF8 to fail, I am certain that I don't want to program to try
continue working after it - it might cause unexplainable issues further on.

The second return value is ignored because WideCharToMultiByte supposedly
checked the string on first call - it shouldn't detect any new issues on next
round.

+    std::auto_ptr<char> converted(new char[size]);
+    WideCharToMultiByte(CP_UTF8, 0, value.c_str(), value.length(), converted.get(), size, 0, 0);
+    std::string string(converted.get(), size);
+    return string;
+  }
+
+  std::string ReadMessage(HANDLE pipe)
+  {
+    std::stringstream stream;
+    std::auto_ptr<char> buffer(new char[bufferSize]);
+    bool doneReading = false;
+    while (!doneReading)
+    {
+      DWORD bytesRead;
+      if (ReadFile(pipe, buffer.get(), bufferSize * sizeof(char), &bytesRead, 0))
+        doneReading = true;
+      else if (GetLastError() != ERROR_MORE_DATA)
+      {
+        std::stringstream stream;
+        stream << "Error reading from pipe: " << GetLastError();
+        throw std::runtime_error(stream.str());
+      }
+      stream << std::string(buffer.get(), bytesRead);
+    }
+    return stream.str();
+  }
+
+  void WriteMessage(HANDLE pipe, const std::string& message)
+  {
+    DWORD bytesWritten;
+    if (!WriteFile(pipe, message.c_str(), message.length(), &bytesWritten, 0)) 
+      throw std::runtime_error("Failed to write to pipe");
+  }
+
+  std::string HandleRequest(const std::vector<std::string>& strings)
+  {
+    std::string procedureName = strings[0];
+    if (procedureName == "Matches")
+      return filterEngine->Matches(strings[1], strings[2], strings[3]) ? "1" : "0";
+    if (procedureName == "GetElementHidingSelectors")
+      return MarshalStrings(filterEngine->GetElementHidingSelectors(strings[1]));
+    return "";
+  }
+
+  DWORD WINAPI ClientThread(LPVOID param)
+  {
+    HANDLE pipe = static_cast<HANDLE>(param);
+
+    try
+    {
+      std::string message = ReadMessage(pipe);
+      std::vector<std::string> strings = UnmarshalStrings(message);
+      std::string response = HandleRequest(strings);
+      WriteMessage(pipe, response);
+    }
+    catch (const std::exception& e)
+    {
+      LogException(e);
+    }
+
+    // TODO: Keep the pipe open until the client disconnects
+    FlushFileBuffers(pipe);
+    DisconnectNamedPipe(pipe);
+    CloseHandle(pipe);
+    return 0;
+  }
+
+  bool IsWindowsVistaOrLater()
+  {
+    OSVERSIONINFOEX osvi;
+    ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
+    osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
+    GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
+    return osvi.dwMajorVersion >= 6;
+  }
+}
+
+std::wstring GetAppDataPath()
+{
+  std::wstring appDataPath;
+  if (IsWindowsVistaOrLater())
+  {
+    WCHAR* pathBuffer;
+    if (FAILED(SHGetKnownFolderPath(FOLDERID_LocalAppDataLow, 0, 0, &pathBuffer)))
+      throw std::runtime_error("Unable to find app data directory");
+    appDataPath.assign(pathBuffer);
+    CoTaskMemFree(pathBuffer);
+  }
+  else
+  { 
+    std::auto_ptr<wchar_t> pathBuffer(new wchar_t[MAX_PATH]); 
+    if (!SHGetSpecialFolderPath(0, pathBuffer.get(), CSIDL_LOCAL_APPDATA, true))
+      throw std::runtime_error("Unable to find app data directory");
+    appDataPath.assign(pathBuffer.get());
+  }
+  return std::wstring(appDataPath) + L"\\AdblockPlus";

[Wladimir Palant, 2013/05/23 14:25:01]

appDataPath already is a wstring, no need to construct a new string here.

[Felix Dahlke, 2013/05/23 19:10:44]

Done.

+}
+
+std::auto_ptr<AdblockPlus::FilterEngine> CreateFilterEngine()
+{
+  // TODO: Pass appInfo in, which should be sent by the client
+  AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::New();
+  std::string dataPath = ToString(GetAppDataPath());
+  dynamic_cast<AdblockPlus::DefaultFileSystem*>(jsEngine->GetFileSystem().get())->SetBasePath(dataPath);
+  std::auto_ptr<AdblockPlus::FilterEngine> filterEngine(new AdblockPlus::FilterEngine(jsEngine));
+  std::vector<AdblockPlus::SubscriptionPtr> subscriptions = filterEngine->FetchAvailableSubscriptions();
+  // TODO: Select a subscription based on the language, not just the first one.
+  //       This should ideally be done in libadblockplus.
+  AdblockPlus::SubscriptionPtr subscription = subscriptions[0];
+  subscription->AddToList();
+  return filterEngine;
+}
+
+HANDLE CreatePipe(const std::wstring& pipeName)
+{
+  SECURITY_ATTRIBUTES sa;
+  memset(&sa, 0, sizeof(SECURITY_ATTRIBUTES));
+  sa.nLength = sizeof(SECURITY_ATTRIBUTES);
+
+  // Low mandatory label. See http://msdn.microsoft.com/en-us/library/bb625958.aspx
+  LPCWSTR accessControlEntry = L"S:(ML;;NW;;;LW)";
+  PSECURITY_DESCRIPTOR securitydescriptor;
+  ConvertStringSecurityDescriptorToSecurityDescriptor(accessControlEntry, SDDL_REVISION_1, &securitydescriptor, 0);
+
+  sa.lpSecurityDescriptor = securitydescriptor;
+  sa.bInheritHandle = TRUE;
+
+  HANDLE pipe = CreateNamedPipe(pipeName.c_str(), PIPE_ACCESS_DUPLEX, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT,
+                                PIPE_UNLIMITED_INSTANCES, bufferSize, bufferSize, 0, &sa);
+  LocalFree(securitydescriptor);
+  return pipe;
+}
+
+int WINAPI WinMain(HINSTANCE, HINSTANCE, LPSTR, int)
+{
+  filterEngine = CreateFilterEngine();
+
+  for (;;)
+  {
+    HANDLE pipe = CreatePipe(pipeName);
+    if (pipe == INVALID_HANDLE_VALUE)
+    {
+      LogLastError("CreateNamedPipe failed");
+      return 1;
+    }
+
+    if (!ConnectNamedPipe(pipe, 0))
+    {
+      LogLastError("Client failed to connect");
+      CloseHandle(pipe);
+      continue;
+    }
+
+    // TODO: Count established connections, kill the engine when none are left
+
+    AutoHandle thread(CreateThread(0, 0, ClientThread, static_cast<LPVOID>(pipe), 0, 0));
+    if (!thread.get())
+    {
+      LogLastError("CreateThread failed");
+      return 1;
+    }
+  }
+
+  return 0;
+}