src/shared/AutoHandle.cpp - Issue 10774005: Avoid duplication between AdblockPlus and AdblockPlusEngine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/shared/AutoHandle.cpp

Issue 10774005: Avoid duplication between AdblockPlus and AdblockPlusEngine (Closed)

Patch Set: Created May 24, 2013, 3:48 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #include PRECOMPILED_HEADER_FILE

	2
	Oleksandr 2013/05/27 15:32:26 It is usually just #include stdafx.h. No need to u It is usually just #include stdafx.h. No need to use the predefined value. Here especially, since stdafx is not available from the "shared" directory. I'd move stdafx.h to the Shared folder or add the Engine folder to Additional Include Folders.
	3 #include "AutoHandle.h"

	4

	5 AutoHandle::AutoHandle()

	6 {

	7 }

	8

	9 AutoHandle::AutoHandle(HANDLE handle) : handle(handle)

	10 {

	11 }

	12

	13 AutoHandle::~AutoHandle()

	14 {

	15 CloseHandle(handle);

	16 }

	17

	18 HANDLE AutoHandle::get()
	Wladimir Palant 2013/05/27 09:51:55 I would rather do this as AutoHandle::operator HAN I would rather do this as AutoHandle::operator HANDLE() - but it's a matter of taste of course. Felix Dahlke 2013/06/04 09:50:40 That's actually nicer, will do. Show quoted text On 2013/05/27 09:51:55, Wladimir Palant wrote: > I would rather do this as AutoHandle::operator HANDLE() - but it's a matter of > taste of course. That's actually nicer, will do.
	19 {

	20 return handle;

	21 }

OLD	NEW