Implement better marshaling

src/plugin/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginDictionary.h"
 #include "PluginHttpRequest.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
@@ skipping 48 matching lines @@
         while ((pipe = OpenPipe(Communication::pipeName)) == INVALID_HANDLE_VALUE)
         {
           const int step = 10;
           Sleep(step);
           timeout -= step;
           if (timeout <= 0)
             throw std::runtime_error("Unable to open Adblock Plus Engine pipe");
         }
       }
 
-      DWORD mode = PIPE_READMODE_MESSAGE; 
-      if (!SetNamedPipeHandleState(pipe, &mode, 0, 0)) 
+      DWORD mode = PIPE_READMODE_MESSAGE;
+      if (!SetNamedPipeHandleState(pipe, &mode, 0, 0))
          throw std::runtime_error("SetNamedPipeHandleState failed");
 
       return pipe;
     }
     catch(std::exception e)
     {
       DEBUG_GENERAL(e.what());
       return INVALID_HANDLE_VALUE;
     }
   }
@@ skipping 122 matching lines @@
   cbData = 50;
   status = RegQueryValueEx(hKey, L"Version", NULL, &type, (BYTE*)version, &cbData);
   if (status != 0)
   {
     return 0;
   }
   RegCloseKey(hKey);
   return (int)(version[0] - 48);
 }
 
-std::string CallAdblockPlusEngineProcedure(const std::vector<std::string>& args)
+Communication::InputBuffer CallAdblockPlusEngineProcedure(Communication::OutputBuffer& message)
 {
   AutoHandle pipe(OpenAdblockPlusEnginePipe());
-  Communication::WriteMessage(pipe.get(), Communication::MarshalStrings(args));
+  Communication::WriteMessage(pipe.get(), message);
   return Communication::ReadMessage(pipe.get());
 }
 
 bool CAdblockPlusClient::Matches(const std::string& url, const std::string& contentType, const std::string& domain)
 {
-  std::vector<std::string> args;
-  args.push_back("Matches");
-  args.push_back(url);
-  args.push_back(contentType);
-  args.push_back(domain);
+  Communication::OutputBuffer request;
+  request << std::string("Matches") << url << contentType << domain;
 
   try
   {
-    std::string response = CallAdblockPlusEngineProcedure(args);
-    return response == "1";
+    Communication::InputBuffer response = CallAdblockPlusEngineProcedure(request);
+
+    bool match;
+    response >> match;
+    return match;
   }
   catch (const std::exception& e)
   {
     DEBUG_GENERAL(e.what());
     return false;
   }
 }
 
-std::vector<std::string> CAdblockPlusClient::GetElementHidingSelectors(std::string domain)
+std::vector<std::string> CAdblockPlusClient::GetElementHidingSelectors(const std::string& domain)
 {
-  std::vector<std::string> args;
-  args.push_back("GetElementHidingSelectors");
-  args.push_back(domain);
+  Communication::OutputBuffer request;
+  request << std::string("GetElementHidingSelectors") << domain;
 
   try
   {
-    std::string response = CallAdblockPlusEngineProcedure(args);
-    return Communication::UnmarshalStrings(response);
+    Communication::InputBuffer response = CallAdblockPlusEngineProcedure(request);
+
+    std::vector<std::string> selectors;
+    int32_t length;
+    response >> length;
+    for (int32_t i = 0; i < length; i++)
+    {
+      std::string selector;
+      response >> selector;
+      selectors.push_back(selector);
+    }
+    return selectors;
   }
   catch (const std::exception& e)
   {
     DEBUG_GENERAL(e.what());
     return std::vector<std::string>();
   }
 }
 
 std::vector<AdblockPlus::SubscriptionPtr> CAdblockPlusClient::FetchAvailableSubscriptions()
 {
@@ skipping 17 matching lines @@
 {
   //TODO: implement this
   return std::vector<AdblockPlus::SubscriptionPtr>();
 }
 
 AdblockPlus::SubscriptionPtr CAdblockPlusClient::GetSubscription(std::string url)
 {
   //TODO: imlement this
   return AdblockPlus::SubscriptionPtr();
 }