Share code for data path retrieval in engine and plugin

src/plugin/PluginSettings.cpp

 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginIniFileW.h"
 #include "PluginIniFile.h"
 #include "PluginSettings.h"
 #include "PluginDictionary.h"
 #include "PluginClient.h"
 #include "PluginChecksum.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
 #include "PluginMutex.h"
 #include "PluginHttpRequest.h"
+#include "../shared/Utils.h"
 #include <memory>
 
 
 // IE functions
 #pragma comment(lib, "iepmapi.lib")
 
 #include <knownfolders.h>
 
 class TSettings
 {
@@ skipping 23 matching lines @@
 
 class CPluginSettingsWhitelistLock : public CPluginMutex
 {
 public:
   CPluginSettingsWhitelistLock() : CPluginMutex("SettingsFileWhitelist", PLUGIN_ERROR_MUTEX_SETTINGS_FILE_WHITELIST) {}
   ~CPluginSettingsWhitelistLock() {}
 };
 
 #endif
 
-WCHAR* CPluginSettings::s_dataPath;
-WCHAR* CPluginSettings::s_dataPathParent;
-
 CPluginSettings* CPluginSettings::s_instance = NULL;
 bool CPluginSettings::s_isLightOnly = false;
 
 CComAutoCriticalSection CPluginSettings::s_criticalSectionLocal;
 #ifdef SUPPORT_WHITELIST
 CComAutoCriticalSection CPluginSettings::s_criticalSectionDomainHistory;
 #endif
 
 
 CPluginSettings::CPluginSettings() :
@@ skipping 69 matching lines @@
     this->SetMainThreadId(lightInstance->m_dwMainThreadId);
     this->SetMainUiThreadId(lightInstance->m_dwMainUiThreadId);
     this->SetWorkingThreadId(lightInstance->m_dwWorkingThreadId);
   }
   Write();
 }
 
 
 CPluginSettings::~CPluginSettings()
 {
-
-  if (s_dataPathParent != NULL)
-  {
-    delete s_dataPathParent;
-  }
   s_instance = NULL;
 }
 
 
 CPluginSettings* CPluginSettings::GetInstance()
 {
   CPluginSettings* instance = NULL;
 
   s_criticalSectionLocal.Lock();
   {
@@ skipping 142 matching lines @@
       CString ver(it->second);
       SetString(SETTING_PLUGIN_UPDATE_VERSION, ver);
       m_isDirty = true;
       DEBUG_SETTINGS("Settings::Configuration plugin update version:" + it->second);
     }
   }
 
   return true;
 }
 
-CString CPluginSettings::GetDataPathParent()
-{
-  if (s_dataPathParent == NULL)
-  {
-    WCHAR* lpData = new WCHAR[MAX_PATH];
-
-    OSVERSIONINFO osVersionInfo;
-    ::ZeroMemory(&osVersionInfo, sizeof(OSVERSIONINFO));
-
-    osVersionInfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
-
-    ::GetVersionEx(&osVersionInfo);
-
-    //Windows Vista       - 6.0
-    //Windows Server 2003 R2  - 5.2
-    //Windows Server 2003   - 5.2
-    //Windows XP        - 5.1
-    if (osVersionInfo.dwMajorVersion >= 6)
-    {
-      if (::SHGetSpecialFolderPath(NULL, lpData, CSIDL_LOCAL_APPDATA, TRUE))
-      {
-        wcscat(lpData, L"Low");
-      }
-      else
-      {
-        DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_SYSINFO, PLUGIN_ERROR_SYSINFO_GET_SPECIAL_FOLDER_LOCAL, "Settings::GetDataPath failed");
-      }
-    }
-    else
-    {
-      if (!SHGetSpecialFolderPath(NULL, lpData, CSIDL_APPDATA, TRUE))
-      {
-        DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_SYSINFO, PLUGIN_ERROR_SYSINFO_GET_SPECIAL_FOLDER, "Settings::GetDataPath failed");
-      }
-    }
-
-    ::PathAddBackslash(lpData);
-
-    s_dataPathParent = lpData;
-
-    if (!::CreateDirectory(s_dataPathParent, NULL))
-    {
-      DWORD errorCode = ::GetLastError();
-      if (errorCode != ERROR_ALREADY_EXISTS)
-      {
-        DEBUG_ERROR_LOG(errorCode, PLUGIN_ERROR_SETTINGS, PLUGIN_ERROR_SETTINGS_CREATE_FOLDER, "Settings::CreateDirectory failed");
-      }
-    }
-  }
-
-  return s_dataPathParent;
-}
-
 CString CPluginSettings::GetDataPath(const CString& filename)
 {
-  if (s_dataPath == NULL)
-  {
-    WCHAR* lpData = new WCHAR[MAX_PATH];
-
-    OSVERSIONINFO osVersionInfo;
-    ::ZeroMemory(&osVersionInfo, sizeof(OSVERSIONINFO));
-
-    osVersionInfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
-
-    ::GetVersionEx(&osVersionInfo);
-
-    //Windows Vista       - 6.0
-    //Windows Server 2003 R2  - 5.2
-    //Windows Server 2003   - 5.2
-    //Windows XP        - 5.1
-    if (osVersionInfo.dwMajorVersion >= 6)
-    {
-      if (::SHGetSpecialFolderPath(NULL, lpData, CSIDL_LOCAL_APPDATA, TRUE))
-      {
-        wcscat(lpData, L"Low");
-      }
-      else
-      {
-        DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_SYSINFO, PLUGIN_ERROR_SYSINFO_GET_SPECIAL_FOLDER_LOCAL, "Settings::GetDataPath failed");
-      }
-    }
-    else
-    {
-      if (!SHGetSpecialFolderPath(NULL, lpData, CSIDL_APPDATA, TRUE))
-      {
-        DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_SYSINFO, PLUGIN_ERROR_SYSINFO_GET_SPECIAL_FOLDER, "Settings::GetDataPath failed");
-      }
-    }
-
-    ::PathAddBackslash(lpData);
-
-    s_dataPath = lpData;
-
-    if (!::CreateDirectory(s_dataPath + CString(USER_DIR), NULL))
-    {
-      DWORD errorCode = ::GetLastError();
-      if (errorCode != ERROR_ALREADY_EXISTS)
-      {
-        DEBUG_ERROR_LOG(errorCode, PLUGIN_ERROR_SETTINGS, PLUGIN_ERROR_SETTINGS_CREATE_FOLDER, "Settings::CreateDirectory failed");
-      }
-    }
-  }
-
-  return s_dataPath + CString(USER_DIR) + filename;
+  std::wstring path = ::GetAppDataPath() + L"\\" + (LPCWSTR)filename;

[Felix Dahlke, 2013/06/04 10:18:09]

Shouldn't this be filename.c_str()? I'd prefer a C++ style cast
(reinterpret_cast) if it has to be a cast.

[Wladimir Palant, 2013/06/04 10:39:03]

It's CString so - no. Changed it into static_cast.

+  return CString(path.c_str());
 }
 
 CString CPluginSettings::GetSystemLanguage()
 {
   CString language;
   CString country;
 
   DWORD bufSize = 256;
   int ccBuf = GetLocaleInfo(LOCALE_SYSTEM_DEFAULT, LOCALE_SISO639LANGNAME, language.GetBufferSetLength(bufSize), bufSize);
   ccBuf = GetLocaleInfo(LOCALE_SYSTEM_DEFAULT, LOCALE_SISO3166CTRYNAME, country.GetBufferSetLength(bufSize), bufSize);
@@ skipping 1148 matching lines @@
     return CString(L"");
 }
 
 
 void CPluginSettings::RefreshFilterlist()
 {
   CPluginClient::GetInstance()->UpdateAllSubscriptions();
 }
 
 #endif // SUPPORT_WHITELIST