New toggle button on First-run page

chrome/content/ui/firstRun.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 75 matching lines @@
     featureSubscriptions.forEach(setToggleSubscriptionButton);
     var filterListener = function(action)
     {
       if (/^subscription\.(added|removed|disabled)$/.test(action))
       {
         for (var i = 0; i < featureSubscriptions.length; i++)
         {
           var featureSubscription = featureSubscriptions[i];
           updateToggleButton(featureSubscription.feature, isSubscriptionEnabled(featureSubscription));
         }
+        
+        setSocialLinks();
       }
     }
     FilterNotifier.addListener(filterListener);
     window.addEventListener("unload", function(event)
     {
       FilterNotifier.removeListener(filterListener);
     }, false);
 
     window.addEventListener("resize", onWindowResize, false);
     document.addEventListener("scroll", onScroll, false);
 
     onWindowResize();
 
-    initSocialLinks(null);
+    setSocialLinks();
   }
 
   function onScroll()
   {
     var currentHeight = document.documentElement.scrollTop + document.body.scrollTop + document.documentElement.clientHeight;
     shade.style.opacity = (document.documentElement.scrollHeight == currentHeight) ? "0.0" : "0.5";
   }
 
   function onWindowResize()
   {
@@ skipping 95 matching lines @@
       }
 
       iframe.removeEventListener("load", popupLoadListener);
     };
     iframe.addEventListener("load", popupLoadListener, false);
 
     iframe.src = url;
     glassPane.className = "visible";
   }
 
-  function initSocialLinks(variant)
+  function setSocialLinks()
   {
+    var isSocialFeatureEnabled = false;
+    for (var i = 0; i < featureSubscriptions.length; i++)
+    {
+      if (featureSubscriptions[i].feature == "social")
+      {
+        isSocialFeatureEnabled = isSubscriptionEnabled(featureSubscriptions[i]);
+        break;
+      }
+    }
+
     var networks = ["twitter", "facebook", "gplus"];
     networks.forEach(function(network)
     {
       var link = E("share-" + network);
-      link.addEventListener("click", function(e)
-      {
-        e.preventDefault();
-        openSharePopup(Utils.getDocLink("share-" + network) + "&variant=" + variant);
-      }, false);
+      if (isSocialFeatureEnabled)
+        link.removeEventListener("click", onSocialLinkClick, false);
+      else
+        link.addEventListener("click", onSocialLinkClick, false);
     });
   }
 
+  function onSocialLinkClick(e)
+  {
+    e.preventDefault();
+    openSharePopup(Utils.getDocLink(e.target.id));
+  }
+
   function setLinks(id)
   {
     var element = E(id);
     if (!element)
       return;
 
     var links = element.getElementsByTagName("a");
     for (var i = 0; i < links.length; i++)
     {
       if (typeof arguments[i + 1] == "string")
@@ skipping 15 matching lines @@
       UI.openFiltersDialog();
     else
     {
       backgroundPage.openOptions();
     }
   }
 
   function updateToggleButton(feature, isEnabled)
   {
     var button = E("toggle-" + feature);
-    button.className = isEnabled ? "disable" : "enable";
-    button.textContent = i18n.getMessage(isEnabled ? "firstRun_action_disable" : "firstRun_action_enable");
+    if (isEnabled)
+      button.className = button.className.replace("enable", "disable");
+    else
+      button.className = button.className.replace("disable", "enable");

[Wladimir Palant, 2013/06/07 14:00:04]

Frankly, one class name should be sufficient here:

  if (isEnabled)
    button.classList.add("enabled");
  else
    button.classList.remove("enabled");

   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();