Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: WixInstaller/Makefile

Issue 10879048: Use minor upgrade mechanism for updates, set installer versionautomatically (Closed)
Left Patch Set: Created June 11, 2013, 1:21 p.m.
Right Patch Set: Looks like I misunderstood nmake documentation, previous change made settings VERSION parameter ext… Created June 12, 2013, 2:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #---------------------------------- 1 #----------------------------------
2 # Makefile for Microsoft NMAKE 2 # Makefile for Microsoft NMAKE
3 # 3 #
4 # Call with only the version parameter to set the default target to all installe rs. 4 # Call with only the version parameter to set the default target to all installe rs.
5 # nmake VERSION=1.2.3 5 # nmake VERSION=1.2.3
6 # Call with a definition of the NMAKE variable ARCH on the command line 6 # Call with a definition of the NMAKE variable ARCH on the command line
7 # nmake VERSION=1.2.3 ARCH=ia32 7 # nmake VERSION=1.2.3 ARCH=ia32
8 # nmake VERSION=1.2.3 ARCH=x64 8 # nmake VERSION=1.2.3 ARCH=x64
9 # If an architecture is specified, the default target is constrained to it. 9 # If an architecture is specified, the default target is constrained to it.
10 #---------------------------------- 10 #----------------------------------
11 11
12 .SUFFIXES: .msi .wixobj .wxs 12 .SUFFIXES: .msi .wixobj .wxs
13 13
14 Build_Dir_common = ..\build\ # 14 Build_Dir_common = ..\build\ #
15 Build_Dir_ia32 = ..\build\ia32\ # comment prevents newline 15 Build_Dir_ia32 = ..\build\ia32\ # comment prevents newline
16 Build_Dir_x64 = ..\build\x64\ # 16 Build_Dir_x64 = ..\build\x64\ #
17
18 !ifndef Configuration
17 Configuration = Release Test 19 Configuration = Release Test
20 !endif
18 21
19 !ifndef VERSION 22 !ifndef VERSION
20 !error VERSION parameter is required 23 VERSION = 99.9
Eric 2013/06/11 15:41:46 Mandating a version number is a needless burden fo
Wladimir Palant 2013/06/12 09:46:34 nmake VERSION=0.8.63333 doesn't look too complicat
Eric 2013/06/12 14:33:24 I've been bitten by typos on the command line alre
21 !endif 24 !endif
22 25
23 #--------------------- 26 #---------------------
24 # Default Targets 27 # Default Targets
25 # 28 #
26 # We change the default rule depending upon the ARCH (architecture) definition. 29 # We change the default rule depending upon the ARCH (architecture) definition.
27 #--------------------- 30 #---------------------
28 31
29 Installer_ia32 = $(Build_Dir_ia32)adblockplusie-$(VERSION)-en-us-ia32.msi 32 Installer_ia32 = $(Build_Dir_ia32)adblockplusie-$(VERSION)-en-us-ia32.msi
30 Installer_x64 = $(Build_Dir_x64)adblockplusie-$(VERSION)-en-us-x64.msi 33 Installer_x64 = $(Build_Dir_x64)adblockplusie-$(VERSION)-en-us-x64.msi
(...skipping 14 matching lines...) Expand all
45 ia32: $(Installer_ia32) 48 ia32: $(Installer_ia32)
46 49
47 x64: $(Installer_x64) 50 x64: $(Installer_x64)
48 51
49 setup: $(Setup) 52 setup: $(Setup)
50 53
51 #--------------------- 54 #---------------------
52 # candle .wxs --> .wixobj 55 # candle .wxs --> .wixobj
53 #--------------------- 56 #---------------------
54 57
55 Candle = candle -nologo -dNoDefault -dVersion=$(VERSION) "-dConfiguration=$(Conf iguration)" $(CANDLE_FLAGS) $(*F).wxs -out $@ 58 Candle = candle -nologo -dNoDefault -dVersion=$(VERSION) "-dConfiguration=$(Conf iguration)" $(CANDLE_FLAGS) $(*F).wxs -out $@
Eric 2013/06/11 15:41:46 No issue here with this modification, since we hav
56 .wxs{$(Build_Dir_common)}.wixobj: 59 .wxs{$(Build_Dir_common)}.wixobj:
57 $(Candle) 60 $(Candle)
58 .wxs{$(Build_Dir_ia32)}.wixobj: 61 .wxs{$(Build_Dir_ia32)}.wixobj:
59 $(Candle) -arch x86 62 $(Candle) -arch x86
60 .wxs{$(Build_Dir_x64)}.wixobj: 63 .wxs{$(Build_Dir_x64)}.wixobj:
61 $(Candle) -arch x64 64 $(Candle) -arch x64
62 65
63 objects_common = $(Build_Dir_common)custom_WixUI_InstallDir.wixobj 66 objects_common = $(Build_Dir_common)custom_WixUI_InstallDir.wixobj
64 objects_ia32 = $(Build_Dir_ia32)adblockplusie.wixobj $(objects_common) 67 objects_ia32 = $(Build_Dir_ia32)adblockplusie.wixobj $(objects_common)
65 objects_x64 = $(Build_Dir_x64)adblockplusie.wixobj $(objects_common) 68 objects_x64 = $(Build_Dir_x64)adblockplusie.wixobj $(objects_common)
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 113
111 install-setup: $(Setup) 114 install-setup: $(Setup)
112 $(Setup) 115 $(Setup)
113 116
114 #--------------------- 117 #---------------------
115 # Miscellaneous 118 # Miscellaneous
116 #--------------------- 119 #---------------------
117 120
118 clean: 121 clean:
119 del $(objects_ia32) 122 del $(objects_ia32)
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld