sitescripts/management/bin/start_services.py - Issue 10942098: Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/management/bin/start_services.py

Issue 10942098: Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil… (Closed)

Patch Set: Created July 4, 2013, 11:23 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # coding: utf-8	1 # coding: utf-8

2	2

3 # This file is part of the Adblock Plus web scripts,	3 # This file is part of the Adblock Plus web scripts,

4 # Copyright (C) 2006-2013 Eyeo GmbH	4 # Copyright (C) 2006-2013 Eyeo GmbH

5 #	5 #

6 # Adblock Plus is free software: you can redistribute it and/or modify	6 # Adblock Plus is free software: you can redistribute it and/or modify

7 # it under the terms of the GNU General Public License version 3 as	7 # it under the terms of the GNU General Public License version 3 as

8 # published by the Free Software Foundation.	8 # published by the Free Software Foundation.

9 #	9 #

10 # Adblock Plus is distributed in the hope that it will be useful,	10 # Adblock Plus is distributed in the hope that it will be useful,

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 continue	51 continue

52 except exceptions.ValueError:	52 except exceptions.ValueError:

53 print "'%s' is not a PID." % pid_string	53 print "'%s' is not a PID." % pid_string

54	54

55 init_path = os.path.join("/etc/init.d", service)	55 init_path = os.path.join("/etc/init.d", service)

56 if not os.path.exists(init_path):	56 if not os.path.exists(init_path):

57 print "%s does not exist, service is not running and cannot be started." % init_path	57 print "%s does not exist, service is not running and cannot be started." % init_path

58 continue	58 continue

59	59

60 print "%s is not running, starting ..." % service	60 print "%s is not running, starting ..." % service

61 subprocess.call([init_path, "start"])	61 subprocess.check_call([init_path, "start"])

OLD	NEW