Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/subscriptions/combineSubscriptions.py

 #!/usr/bin/env python
 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
@@ skipping 69 matching lines @@
     oldData = re.sub(r'\s*\d+ \w+ \d+ \d+:\d+ UTC', '', oldData)
     newData = re.sub(checksumRegExp, '', data)
     newData = re.sub(r'\s*\d+ \w+ \d+ \d+:\d+ UTC', '', newData)
     if oldData == newData:
       changed = False
   if changed:
     handle = codecs.open(filePath, 'wb', encoding='utf-8')
     handle.write(data)
     handle.close()
     try:
-      subprocess.Popen(['7za', 'a', '-tgzip', '-mx=9', '-bd', '-mpass=15', filePath + '.gz', filePath], stdout=subprocess.PIPE).communicate()
+      subprocess.check_output(['7za', 'a', '-tgzip', '-mx=9', '-bd', '-mpass=15', filePath + '.gz', filePath])
     except:
       print >>sys.stderr, 'Failed to compress file %s. Please ensure that p7zip is installed on the system.' % filePath
 
 def processVerbatimFile(sourceDir, targetDir, file):
   handle = codecs.open(os.path.join(sourceDir, file), 'rb', encoding='utf-8')
   conditionalWrite(os.path.join(targetDir, file), handle.read())
   handle.close()
 
 def processSubscriptionFile(sourceName, sourceDirs, targetDir, file, timeout):
   sourceDir = sourceDirs[sourceName]
@@ skipping 221 matching lines @@
   timeout = 30
   for option, value in opts:
     if option in ('-h', '--help'):
       usage()
       sys.exit()
     elif option in ('-t', '--timeout'):
       timeout = int(value)
 
   if os.path.exists(os.path.join(sourceDir, '.hg')):
     # Our source is a Mercurial repository, try updating
-    subprocess.Popen(['hg', '-R', sourceDir, 'pull', '--update']).communicate()
+    subprocess.check_call(['hg', '-q', '-R', sourceDir, 'pull', '--update'])
 
   combineSubscriptions(sourceDir, targetDir, timeout)