Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/extensions/bin/updateDownloadLinks.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 172 matching lines @@
     command = ['hg', '-R', repo.repository, 'cat', '-r', version, os.path.join(repo.repository, 'AndroidManifest.xml')]
     result = subprocess.check_output(command)
     manifest = dom.parseString(result)
     usesSdk = manifest.getElementsByTagName('uses-sdk')[0]
 
     return {
       'revision': revision,
       'minSdkVersion': usesSdk.attributes["android:minSdkVersion"].value,
     }
   else:
-    try:
+    files = subprocess.check_output(['hg', '-R', repo.repository, 'locate', '-r', version]).splitlines()
+    if 'metadata.%s' % repo.type in files:
       command = ['hg', '-R', repo.repository, 'cat', '-r', version, os.path.join(repo.repository, 'metadata.%s' % repo.type)]
       result = subprocess.check_output(command)
-    except:
+    else:
       # Fall back to platform-independent metadata file for now
       command = ['hg', '-R', repo.repository, 'cat', '-r', version, os.path.join(repo.repository, 'metadata')]
       result = subprocess.check_output(command)
 
     parser = SafeConfigParser()
     parser.readfp(StringIO(result))
 
     result = {
       'extensionID': parser.get('general', 'id'),
       'version': version,
@@ skipping 35 matching lines @@
   result = SafeConfigParser()
   getDownloadLinks(result)
   file = open(get_config().get('extensions', 'downloadLinksFile'), 'wb')
   result.write(file)
   file.close()
 
   writeUpdateManifest(result)
 
 if __name__ == "__main__":
   updateLinks()