Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/extensions/bin/updateRecommendations.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 10 matching lines @@
 from tempfile import mkdtemp
 from shutil import rmtree
 
 def updateRecommendations():
   repository = get_config().get('extensions', 'abp_repository')
   tempdir = mkdtemp(prefix='adblockplus')
   try:
     subprocess.check_call(['hg', 'clone', '-q', '-U', repository, tempdir])
     subprocess.check_call(['hg', 'up', '-q', '-R', tempdir, '-r', 'default'])
     writeSubscriptions('recommendations', os.path.join(tempdir, 'chrome', 'content', 'ui', 'subscriptions.xml'))
-    subprocess.check_call(['hg', 'commit', '-q', '-R', tempdir, '-u', 'hgbot', '-m', 'Updated list of recommended subscriptions'])
-
-    # Don't check the result of this call, it will be 1 if nothing needs pushing
-    subprocess.call(['hg', 'push', '-q', '-R', tempdir])
+    if subprocess.check_output(['hg', 'stat', '-R', tempdir]) != '':
+      subprocess.check_call(['hg', 'commit', '-q', '-R', tempdir, '-u', 'hgbot', '-m', 'Updated list of recommended subscriptions'])
+      subprocess.check_call(['hg', 'push', '-q', '-R', tempdir])
   finally:
     rmtree(tempdir)
 
 if __name__ == '__main__':
   setupStderr()
   updateRecommendations()