Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/subscriptions/bin/updateMalwareDomainsList.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 29 matching lines @@
 
     data = urllib.urlopen('http://mirror3.malwaredomains.com/files/justdomains.zip').read()
     zip = zipfile.ZipFile(StringIO(data), 'r')
     info = zip.infolist()[0]
     for line in str(zip.read(info.filename)).splitlines():
       if not line:
         continue
       print >>file, '||%s^' % line.strip().decode('iso-8859-1')
     file.close();
 
-    subprocess.check_call(['hg', '-q', 'commit', '-R', tempdir, '-A', '-u', 'hgbot', '-m', 'Updated malwaredomains.com data'])
-
-    # Don't check the result of this call, it will be 1 if nothing needs pushing
-    subprocess.call(['hg', '-q', 'push', '-R', tempdir])
+    if subprocess.check_output(['hg', 'stat', '-R', tempdir]) != '':
+      subprocess.check_call(['hg', '-q', 'commit', '-R', tempdir, '-A', '-u', 'hgbot', '-m', 'Updated malwaredomains.com data'])
+      subprocess.call(['hg', '-q', 'push', '-R', tempdir])

[Sebastian Noack, 2013/07/05 22:06:08]

If I understand it correctly, you check with hg stat whether there is something
to push. So you don't have to silently ignore failure of hg push, anymore.

   finally:
     shutil.rmtree(tempdir, ignore_errors=True)