Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/subscriptions/knownIssuesParser.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 132 matching lines @@
   resetMatches(rules)
 
   result = result.keys()
   result.sort()
   return result
 
 @cached(600)
 def getRules():
   repoPath = os.path.abspath(get_config().get('subscriptions', 'repository'))
 
-  (data, errors) = subprocess.Popen(['hg', '-R', repoPath, 'cat', '-r', 'default', os.path.join(repoPath, 'knownIssues')], stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()
-  if errors:
-    print >>sys.stderr, errors
-
+  data = subprocess.check_output(['hg', '-q', '-R', repoPath, 'cat', '-r', 'default', os.path.join(repoPath, 'knownIssues')])

[Sebastian Noack, 2013/07/04 13:57:51]

The added -q parameter doesn't seem to have any affect, because of neither the
ouput of the content of the given file, nor error messages are affected by hg's
-q parameter.

[Wladimir Palant, 2013/07/05 11:24:33]

Oops, I was a bit over-eager adding -q to all hg commands - check_output() calls
obviously don't need it.

   data = data.decode('utf-8').replace('\r', '').split('\n')
   data.append('[]')   # Pushes out last section
 
   rules = {}
   rulesets = []
 
   ruleset = None
   for line in data:
     commentIndex = line.find('#')
     if commentIndex >= 0:
@@ skipping 59 matching lines @@
         continue
 
       value = ' '.join(foundAttrs)
       if requiredValue != None:
         if requiredValue != value:
           continue
         value = text
 
       checkMatch(rules, key, value)
   return extractMatches(rules, rulesets, lang)