sitescripts/extensions/bin/createNightlies.py - Issue 10942098: Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/extensions/bin/createNightlies.py

Issue 10942098: Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil… (Closed)

Patch Set: Addressed issues Created July 5, 2013, 11:22 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/extensions/bin/createNightlies.py

===================================================================

--- a/sitescripts/extensions/bin/createNightlies.py

+++ b/sitescripts/extensions/bin/createNightlies.py

@@ -263,17 +263,17 @@ class NightlyBuild(object):

apkFile = open(outputPath, 'wb')

try:

port = get_config().get('extensions', 'androidBuildPort')

except ConfigParser.NoOptionError:

port = '22'

buildCommand = ['ssh', '-p', port, get_config().get('extensions', 'androidBuildHost')]

- buildCommand += map(pipes.quote, ['/home/android/bin/makedebugbuild.py', '--revision', self.revision, '--version', self.version, '--stdout'])

+ buildCommand.extend(map(pipes.quote, ['/home/android/bin/makedebugbuild.py', '--revision', self.revision, '--version', self.version, '--stdout']))

subprocess.check_call(buildCommand, stdout=apkFile, close_fds=True)

except:

# clear broken output if any

if os.path.exists(outputPath):

os.remove(outputPath)

raise

elif self.config.type == 'chrome' or self.config.type == 'opera':

import buildtools.packagerChrome as packager