Unified Diff: sitescripts/subscriptions/bin/updateMalwareDomainsList.py
Issue 10942098:
Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil… (Closed)
Patch Set:
Created July 8, 2013, 9:03 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: sitescripts/subscriptions/bin/updateMalwareDomainsList.py |
| =================================================================== |
| --- a/sitescripts/subscriptions/bin/updateMalwareDomainsList.py |
| +++ b/sitescripts/subscriptions/bin/updateMalwareDomainsList.py |
| @@ -44,11 +44,11 @@ if __name__ == '__main__': |
| for line in str(zip.read(info.filename)).splitlines(): |
| if not line: |
| continue |
| print >>file, '||%s^' % line.strip().decode('iso-8859-1') |
| file.close(); |
| if subprocess.check_output(['hg', 'stat', '-R', tempdir]) != '': |
| subprocess.check_call(['hg', '-q', 'commit', '-R', tempdir, '-A', '-u', 'hgbot', '-m', 'Updated malwaredomains.com data']) |
| - subprocess.call(['hg', '-q', 'push', '-R', tempdir]) |
| + subprocess.check_call(['hg', '-q', 'push', '-R', tempdir]) |
| finally: |
| shutil.rmtree(tempdir, ignore_errors=True) |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
