Fix domain-based whitelisting

src/plugin/PluginSettings.cpp

 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginIniFileW.h"
 #include "PluginIniFile.h"
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginChecksum.h"
 #include "PluginSystem.h"
@@ skipping 1259 matching lines @@
       isRead = false;
     }
 
     return isRead;
 }
 
 
 void CPluginSettings::AddWhiteListedDomain(const CString& domain)
 {
   DEBUG_SETTINGS("SettingsWhitelist::AddWhiteListedDomain domain:" + domain)
-
-  RefreshWhitelist();
-  if (IsWhiteListedDomain(domain))
-    return;

[Wladimir Palant, 2013/06/17 09:33:56]

I think that this code block is unnecessary and merely wastes time - the engine
won't add a filter twice.

[Felix Dahlke, 2013/06/17 11:19:01]

Done.

-
-  s_criticalSectionLocal.Lock();

[Wladimir Palant, 2013/06/17 09:33:56]

Please remove the pointless critical section use here.

[Felix Dahlke, 2013/06/17 11:19:01]

Done.

   CPluginClient::GetInstance()->AddFilter(CreateDomainWhitelistingFilter(domain));
-  s_criticalSectionLocal.Unlock();
 }
 
 void CPluginSettings::RemoveWhiteListedDomain(const CString& domain)
 {
   DEBUG_SETTINGS("SettingsWhitelist::RemoveWhiteListedDomain domain:" + domain)
-
-  RefreshWhitelist();
-  if (!IsWhiteListedDomain(domain))
-    return;

[Wladimir Palant, 2013/06/17 09:33:56]

I think that this code block is unnecessary and merely wastes time - the engine
won't remove a filter twice.

[Felix Dahlke, 2013/06/17 11:19:01]

Done.

-
-  s_criticalSectionLocal.Lock();

[Wladimir Palant, 2013/06/17 09:33:56]

Please remove the pointless critical section use here.

[Felix Dahlke, 2013/06/17 11:19:01]

Done.

   CPluginClient::GetInstance()->RemoveFilter(CreateDomainWhitelistingFilter(domain));
-  s_criticalSectionLocal.Unlock();
 }
 
 bool CPluginSettings::IsWhiteListedDomain(const CString& domain) const
 {
   bool bIsWhiteListed;
 
   s_criticalSectionLocal.Lock();
   {
     bIsWhiteListed = std::find(m_whitelistedDomains.begin(), m_whitelistedDomains.end(), std::string(CW2A(domain, CP_UTF8))) != m_whitelistedDomains.end();
   }
@@ skipping 87 matching lines @@
     return CString(L"");
 }
 
 
 void CPluginSettings::RefreshFilterlist()
 {
   CPluginClient::GetInstance()->UpdateAllSubscriptions();
 }
 
 #endif // SUPPORT_WHITELIST