Fix domain whitelisting and remove unused code

src/plugin/PluginClientBase.cpp

 #include "PluginStdAfx.h"
 
 // Internet / FTP
 #include <wininet.h>
 
 // IP adapter
 #include <iphlpapi.h>
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
@@ skipping 137 matching lines @@
 
       hasError = true;
 
       s_pluginErrors.erase(it);
     }
   }
   s_criticalSectionLocal.Unlock();
 
   return hasError;
 }
-
-// ============================================================================
-// Whitelisting
-// ============================================================================
-
-#ifdef SUPPORT_WHITELIST
-
-bool CPluginClientBase::IsUrlWhiteListed(const CString& url)
-{
-  if (url.IsEmpty())
-  {
-    return false;
-  }
-
-  int pos = 0;
-  CString scheme = url.Find('/',pos) >= 0 ? url.Tokenize(L"/", pos) : L"";
-  CString domain = ExtractDomain(url);
-  if (scheme == L"res:" || scheme == L"file:")

[Felix Dahlke, 2013/06/25 09:46:58]

Do you think excluding some schemes is still necessary? I figured leaving it to
Matches() should do.

[Wladimir Palant, 2013/06/25 12:00:40]

Yes, leaving it to Matches() is more consistent to what we do in Firefox. There
is a list of schemes that we never block, file: being one of them. Still, a
document loaded from file: isn't immediately whitelisted, requests to http
resources made from it can still be blocked. This used to be different but
people were complaining because they saved web pages locally and suddenly
started seeing ads.

[Oleksandr, 2013/06/25 12:13:58]

We should do as little as possible with these. Especially with res:// links -
those show IE's UI, and IE usually behaves very freely with those, causing the
most weird errors. Since this is IE specific, and Matches isn't IE specific, and
also since Matches uses IPC, which is a heavy operation, I would suggest against
excluding this.  
On 2013/06/25 09:46:58, Felix H. Dahlke wrote:

-  {
-    return true;
-  }
-
-  // TODO: Caching whitelist entries in PluginSettings is redundant and wasteful. We should have an engine call for IsWhitelistedDomain.
-  CPluginSettings* pluginSettings = CPluginSettings::GetInstance();
-  pluginSettings->RefreshWhitelist();
-  return pluginSettings->IsWhiteListedDomain(domain);
-}
-
-#endif // SUPPORT_WHITELIST