Fix domain whitelisting and remove unused code

src/plugin/PluginTabBase.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginClient.h"
 #include "PluginSettings.h"
 #ifdef SUPPORT_CONFIG
 #include "PluginConfig.h"
 #endif
 #include "PluginTab.h"
 #include "PluginDomTraverser.h"
 #include "PluginClass.h"
@@ skipping 12 matching lines @@
 #endif
 #ifdef SUPPORT_CONFIG
 int CPluginTabBase::s_configVersion = 0;
 #endif
 
 namespace
 {
   CString ExtractDomain(const CString& url)
   {
     int pos = 0;
-    CString scheme = url.Find('/', pos) >= 0 ? url.Tokenize(L"/", pos) : L"";
+    if (url.Find('/', pos) >= 0)
+      url.Tokenize(L"/", pos);
     CString domain = url.Tokenize(L"/", pos);
     domain.MakeLower();
     return domain;
   }
 }
 
 CPluginTabBase::CPluginTabBase(CPluginClass* plugin) : m_plugin(plugin), m_isActivated(false)
 {
   m_filter = std::auto_ptr<CPluginFilter>(new CPluginFilter());
 
@@ skipping 216 matching lines @@
   {
     domain = m_documentDomain;
   }
   m_criticalSection.Unlock();
 
   return domain;
 }
 
 void CPluginTabBase::SetDocumentUrl(const CString& url)
 {
   CString domain;

[Wladimir Palant, 2013/06/25 11:55:13]

This variable is unused.

[Wladimir Palant, 2013/06/25 18:03:58]

Still unused, feel free to remove while you are at it.

[Felix Dahlke, 2013/06/26 09:32:55]

Done.

 
   m_criticalSection.Lock();
   {
     m_documentUrl = url;
     m_documentDomain = ExtractDomain(url);
 
     domain = m_documentDomain;
   }
   m_criticalSection.Unlock();
 }
@@ skipping 165 matching lines @@
 
         // Non-hanging sleep
         Sleep(50);
       }
 
       tabLoopIteration++;
   }
 
   return 0;
 }