Cleanup

src/plugin/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
 
 #include "AdblockPlusClient.h"
@@ skipping 366 matching lines @@
 
   try
   {
     CallAdblockPlusEngineProcedure(request);
   }
   catch (const std::exception& e)
   {
     DEBUG_GENERAL(e.what());
   }
 }
+
+void CAdblockPlusClient::SetPref(const std::wstring& name, const std::wstring& value)
+{
+  Communication::OutputBuffer request;
+  request << Communication::PROC_SET_PREF << ToUtf8String(name) << ToUtf8String(value);
+
+  try
+  {
+    CallAdblockPlusEngineProcedure(request);
+  }
+  catch (const std::exception& e)
+  {
+    DEBUG_GENERAL(e.what());
+  }
+}
+
+std::wstring CAdblockPlusClient::GetPref(const std::wstring& name)
+{
+  Communication::OutputBuffer request;
+  request << Communication::PROC_GET_PREF << ToUtf8String(name);
+
+  try
+  {
+    Communication::InputBuffer response = CallAdblockPlusEngineProcedure(request);
+    std::vector<std::wstring> retValue = ReadStrings(response);
+    return retValue.size() > 0 ? retValue.at(0) : L"";

[Wladimir Palant, 2013/07/11 12:53:10]

This really shouldn't try to read a list of strings if we are only talking about
a single string at most. Also, you shouldn't use ReadStrings() on something that
wasn't written via WriteStrings() - if somebody decides to change WriteStrings()
later he will certainly update ReadStrings() to match but he won't look at the
piece of code here. Better:

  bool success;
  response >> success;
  if (success)
  {
    std::string value;
    response >> value;
    return FromUtf8String(value);
  }
  else
    return L"";

+  }
+  catch (const std::exception& e)
+  {
+    DEBUG_GENERAL(e.what());
+    return L"";
+  }
+}