Cleanup

src/plugin/PluginDebug.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginDebug.h"
 #include "PluginMutex.h"
 #include "PluginSettings.h"
 
 
 class CPluginDebugLock : public CPluginMutex
 {
 
@@ skipping 25 matching lines @@
   CONSOLE(CT2A(text.GetString(), CP_UTF8));
 #endif
 
   if (CPluginSettings::HasInstance())
   {
 #ifdef ENABLE_DEBUG_SPLIT_FILE
     CPluginSettings* settings = CPluginSettings::GetInstance();
 
     bool isWorkingThread = settings->IsWorkingThread(dwThreadId);
 
     CString processor;

[Wladimir Palant, 2013/07/11 12:53:10]

Aren't you leaving that variable uninitialized? How about:

if (isWorkingThread)
  processor = L"tab" + ::GetCurrentProcessId() + L"_thread";
else
  processor = L"tab" + ::GetCurrentProcessId() + L"_ui";

[Oleksandr, 2013/07/22 00:48:16]

Process ID isn't really a reliable identifier here. One process can host 5 tabs
as well as 1 tab.

On 2013/07/11 12:53:10, Wladimir Palant wrote:

-    if (settings->IsMainProcess(dwProcessId) && settings->IsMainThread(dwThreadId))
-    {
-      processor = L"main_thread";
-    }
-    else if (settings->IsMainProcess(dwProcessId) && settings->IsMainUiThread(dwThreadId))
-    {
-      processor = L"main_ui";
-    }
-    else if (isWorkingThread)
-    {
-      processor = L"tab" + settings->GetTabNumber() + L"_thread";
-    }
-    else
-    {
-      processor = L"tab" + settings->GetTabNumber() + L"_ui";
-    }
 #else
     if (dwProcessId == 0)
     {
       dwProcessId = ::GetCurrentProcessId();
     }
     if (dwThreadId == 0)
     {
       dwThreadId = ::GetCurrentThreadId();
     }
 
@@ skipping 174 matching lines @@
     srcTrunc = src.Left(67) + L"..." + src.Right(30);
   }
 
   CString blocking;
   blocking.Format(L"Ignored  %-12s  %s  %s", type, domain.IsEmpty()? L"-" : domain, srcTrunc);
 
   DebugResult(blocking);
 }
 
 #endif // ENABLE_DEBUG_RESULT_IGNORED