src/plugin/PluginSystem.cpp - Issue 11013110: Cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/PluginSystem.cpp

Issue 11013110: Cleanup (Closed)

Left Patch Set: SetPref/GetPref type safety. Comments addressed. Created July 22, 2013, 12:42 a.m.

Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 #include "PluginStdAfx.h"	1 #include "PluginStdAfx.h"

2	2

3 // Internet / FTP	3 // Internet / FTP

4 #include <wininet.h>	4 #include <wininet.h>

5	5

6 // IP adapter	6 // IP adapter

7 #include <iphlpapi.h>	7 #include <iphlpapi.h>

8	8

9 #include "PluginSystem.h"	9 #include "PluginSystem.h"

10 #include "PluginClient.h"	10 #include "PluginClient.h"

11 #include "PluginSha1.h"

12 #include "PluginSettings.h"	11 #include "PluginSettings.h"

13	12

14	13

15 // IP adapter	14 // IP adapter

16 #pragma comment(lib, "IPHLPAPI.lib")	15 #pragma comment(lib, "IPHLPAPI.lib")

17	16

18 // IE functions	17 // IE functions

19 #pragma comment(lib, "iepmapi.lib")	18 #pragma comment(lib, "iepmapi.lib")

20	19

21 // Internet / FTP	20 // Internet / FTP

(...skipping 107 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
129 // Close the handler	128 // Close the handler

130 ::RegCloseKey(hKey);	129 ::RegCloseKey(hKey);

131 }	130 }

132 else	131 else

133 {	132 {

134 DEBUG_ERROR_LOG(res, PLUGIN_ERROR_OS_VERSION, PLUGIN_ERROR_OS_VERSION_REG_OP EN_KEY, L"Client::GetBrowserVer - Failed reg open");	133 DEBUG_ERROR_LOG(res, PLUGIN_ERROR_OS_VERSION, PLUGIN_ERROR_OS_VERSION_REG_OP EN_KEY, L"Client::GetBrowserVer - Failed reg open");

135 }	134 }

136	135

137 return browserVersion;	136 return browserVersion;

138 }	137 }

LEFT	RIGHT