Cleanup

src/engine/main.cpp

 #include <AdblockPlus.h>
 #include <functional>
 #include <vector>
 #include <Windows.h>
 
 #include "../shared/AutoHandle.h"
 #include "../shared/Communication.h"
 #include "../shared/Dictionary.h"
 #include "../shared/Utils.h"
 #include "../shared/Version.h"
@@ skipping 179 matching lines @@
         request >> name;
 
         AdblockPlus::JsValuePtr valuePtr = filterEngine->GetPref(name);
         if (valuePtr->IsNull() || valuePtr->IsUndefined())
         {
           // Report no success
           response << false;
           break;
         }
 
-        // Report success
-        response << true;

[Felix Dahlke, 2013/07/25 13:52:33]

So anything that is not bool, int or string will report success but not add any
value?

         
         if (valuePtr->IsBool())
         {
+          response << true;
           response << valuePtr->AsBool();
         }
         else if (valuePtr->IsNumber())
         {
+          response << true;
           response << valuePtr->AsInt();
         }
         else if (valuePtr->IsString())
         {
+          response << true;
           response << valuePtr->AsString();
+        }
+        else
+        {
+          // Report failure
+          response << false;
         }
         break;
       }
 
     }
     return response;
   }
 
   DWORD WINAPI ClientThread(LPVOID param)
   {
@@ skipping 95 matching lines @@
     }
     catch (std::runtime_error e)
     {
       DebugException(e);
       return 1;
     }
   }
 
   return 0;
 }