src/plugin/AdblockPlusTab.cpp - Issue 11013110: Cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/AdblockPlusTab.cpp

Issue 11013110: Cleanup (Closed)

Left Patch Set: Whole cleanup + comments addressed Created July 23, 2013, 11:34 a.m.

Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #include "PluginStdAfx.h"	1 #include "PluginStdAfx.h"

2	2

3 #include "PluginSettings.h"	3 #include "PluginSettings.h"

4 #include "PluginSystem.h"	4 #include "PluginSystem.h"

5 #include "PluginClass.h"	5 #include "PluginClass.h"

6 #include "PluginClientFactory.h"	6 #include "PluginClientFactory.h"

7	7

8 #include "AdblockPlusTab.h"	8 #include "AdblockPlusTab.h"

9	9

10	10

11 CPluginTab::CPluginTab(CPluginClass* plugin) : CPluginTabBase(plugin)	11 CPluginTab::CPluginTab(CPluginClass* plugin) : CPluginTabBase(plugin)

12 {	12 {

13 }	13 }

14	14

15 CPluginTab::~CPluginTab()	15 CPluginTab::~CPluginTab()

16 {	16 {

17 }	17 }

18

19

20 void CPluginTab::OnNavigate(const CString& url)
Felix Dahlke 2013/07/25 13:52:33 I don't think there's any point in overwriting thi I don't think there's any point in overwriting this function anymore. Oleksandr 2013/07/26 14:20:04 You're right. I'd still leave the CPuginTab class You're right. I'd still leave the CPuginTab class as an abstraction for future. On 2013/07/25 13:52:33, Felix H. Dahlke wrote: Show quoted text > I don't think there's any point in overwriting this function anymore.
21 {

22 CPluginTabBase::OnNavigate(url);

23 }

LEFT	RIGHT