Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: src/plugin/DownloadSource.h
Issue
11013110
:
Cleanup (Closed)
Left Patch Set: Refactoring CallAdblockPlusEngine
Created July 24, 2013, 9:09 a.m.
Right Patch Set: More beautification and addressing comments
Created July 29, 2013, 12:13 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing …
Patch Set 3: SetPref/GetPref type safety. Comments addressed.
Patch Set 4: Whole cleanup + comments addressed
Patch Set 5: Refactoring CallAdblockPlusEngine
Patch Set 6: Minor CallEngine refactoring
Patch Set 7: More beautification and addressing comments
Right:
Patch Set 1: None
Patch Set 2: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing …
Patch Set 3: SetPref/GetPref type safety. Comments addressed.
Patch Set 4: Whole cleanup + comments addressed
Patch Set 5: Refactoring CallAdblockPlusEngine
Patch Set 6: Minor CallEngine refactoring
Patch Set 7: More beautification and addressing comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgsubstate
adblockplus.gyp
src/engine/main.cpp
src/plugin/AdblockPlus.rc
src/plugin/AdblockPlusClient.h
src/plugin/AdblockPlusClient.cpp
src/plugin/AdblockPlusTab.h
src/plugin/AdblockPlusTab.cpp
src/plugin/Config.h
src/plugin/DownloadSource.h
src/plugin/Plugin.cpp
src/plugin/PluginChecksum.h
src/plugin/PluginChecksum.cpp
src/plugin/PluginClass.h
src/plugin/PluginClass.cpp
src/plugin/PluginClassThread.cpp
src/plugin/PluginClientBase.cpp
src/plugin/PluginConfig.h
src/plugin/PluginConfig.cpp
src/plugin/PluginConfiguration.h
src/plugin/PluginConfiguration.cpp
src/plugin/PluginDebug.cpp
src/plugin/PluginFilter.cpp
src/plugin/PluginHttpRequest.h
src/plugin/PluginHttpRequest.cpp
src/plugin/PluginIniFile.h
src/plugin/PluginIniFile.cpp
src/plugin/PluginIniFileW.h
src/plugin/PluginIniFileW.cpp
src/plugin/PluginSelftest.h
src/plugin/PluginSettings.h
src/plugin/PluginSettings.cpp
src/plugin/PluginSha1.h
src/plugin/PluginSha1.cpp
src/plugin/PluginSystem.cpp
src/plugin/PluginTabBase.h
src/plugin/PluginTabBase.cpp
src/plugin/PluginUserSettings.cpp
src/plugin/PluginWbPassThrough.cpp
src/plugin/Resource.h
src/shared/Communication.h
src/shared/Communication.cpp
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« src/plugin/Config.h
('k') |
src/plugin/Plugin.cpp »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
#define DOWNLOAD_SOURCE "test"
LEFT
RIGHT
« src/plugin/Config.h
('k') |
src/plugin/Plugin.cpp »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 11013110: Cleanup (Closed)
Created July 5, 2013, 3:28 a.m. by Oleksandr
Modified Aug. 8, 2013, 2:25 p.m.
Reviewers: Wladimir Palant, Felix Dahlke
Base URL:
Comments: 88
This is Rietveld