Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: src/plugin/PluginSettings.h

Issue 11013110: Cleanup (Closed)
Left Patch Set: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing … Created July 9, 2013, 12:59 p.m.
Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/PluginSelftest.h ('k') | src/plugin/PluginSettings.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /** 1 /**
2 * This class contains all client functionality of the IE plugin 2 * This class contains all client functionality of the IE plugin
3 * 3 *
4 * Exception errors are tested by calls to ExceptionsTest from: Main ... 4 * Exception errors are tested by calls to ExceptionsTest from: Main ...
5 */ 5 */
6 6
7 #ifndef _PLUGIN_SETTINGS_H_ 7 #ifndef _PLUGIN_SETTINGS_H_
8 #define _PLUGIN_SETTINGS_H_ 8 #define _PLUGIN_SETTINGS_H_
9 9
10 10
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 public: 54 public:
55 55
56 typedef std::map<CString, CString> TProperties; 56 typedef std::map<CString, CString> TProperties;
57 57
58 private: 58 private:
59 59
60 bool m_isFirstRun; 60 bool m_isFirstRun;
61 61
62 DWORD m_dwWorkingThreadId; 62 DWORD m_dwWorkingThreadId;
63 63
64 CString m_settingsVersion;
Wladimir Palant 2013/07/11 12:53:10 Still unused.
65
66 static CComAutoCriticalSection s_criticalSectionLocal; 64 static CComAutoCriticalSection s_criticalSectionLocal;
67 65
68 void Clear(); 66 void Clear();
69 67
70 // Private constructor used by the singleton pattern 68 // Private constructor used by the singleton pattern
71 CPluginSettings(); 69 CPluginSettings();
72 public: 70 public:
73 71
74 ~CPluginSettings(); 72 ~CPluginSettings();
75 73
76 static CPluginSettings* s_instance; 74 static CPluginSettings* s_instance;
77 75
78 static bool s_isLightOnly;
Wladimir Palant 2013/07/11 12:53:10 Still unused.
79 static bool HasInstance(); 76 static bool HasInstance();
80 static CPluginSettings* GetInstance(); 77 static CPluginSettings* GetInstance();
81 78
82 static CString GetDataPath(const CString& filename=L""); 79 static CString GetDataPath(const CString& filename=L"");
83 80
84 bool IsPluginEnabled() const; 81 bool IsPluginEnabled() const;
85 82
86 std::map<CString, CString> GetFilterLanguageTitleList() const; 83 std::map<CString, CString> GetFilterLanguageTitleList() const;
87 84
88 void SetWorkingThreadId(); 85 void SetWorkingThreadId();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 void SetDefaultSubscription(); 128 void SetDefaultSubscription();
132 CString GetSubscription(); 129 CString GetSubscription();
133 130
134 bool GetStatusBarAsked(); 131 bool GetStatusBarAsked();
135 void SetStatusBarAsked(); 132 void SetStatusBarAsked();
136 std::vector<SubscriptionDescription> m_subscriptions; 133 std::vector<SubscriptionDescription> m_subscriptions;
137 }; 134 };
138 135
139 136
140 #endif // _PLUGIN_SETTINGS_H_ 137 #endif // _PLUGIN_SETTINGS_H_
LEFTRIGHT
« src/plugin/PluginSelftest.h ('k') | src/plugin/PluginSettings.cpp » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld