src/plugin/PluginTabBase.h - Issue 11013110: Cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/PluginTabBase.h

Issue 11013110: Cleanup (Closed)

Left Patch Set: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing … Created July 9, 2013, 12:59 p.m.

Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 #ifndef _PLUGIN_TAB_BASE_H_	1 #ifndef _PLUGIN_TAB_BASE_H_

2 #define _PLUGIN_TAB_BASE_H_	2 #define _PLUGIN_TAB_BASE_H_

3	3

4	4

5 #ifdef SUPPORT_DOM_TRAVERSER	5 #ifdef SUPPORT_DOM_TRAVERSER

6 class CPluginDomTraverser;	6 class CPluginDomTraverser;

7 #endif	7 #endif

8	8

9 #include "PluginUserSettings.h"	9 #include "PluginUserSettings.h"

10 #include "PluginFilter.h"	10 #include "PluginFilter.h"

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 public:	64 public:

65	65

66 CPluginTabBase(CPluginClass* plugin);	66 CPluginTabBase(CPluginClass* plugin);

67 ~CPluginTabBase();	67 ~CPluginTabBase();

68	68

69 CString GetDocumentDomain();	69 CString GetDocumentDomain();

70 CString GetDocumentUrl();	70 CString GetDocumentUrl();

71	71

72 virtual void OnActivate();	72 virtual void OnActivate();

73 virtual void OnUpdate();	73 virtual void OnUpdate();

74 virtual bool OnUpdateSettings(bool forceUpdate);

75 virtual bool OnUpdateConfig();

76 virtual void OnNavigate(const CString& url);	74 virtual void OnNavigate(const CString& url);

77 virtual void OnDownloadComplete(IWebBrowser2* browser);	75 virtual void OnDownloadComplete(IWebBrowser2* browser);

78 virtual void OnDocumentComplete(IWebBrowser2* browser, const CString& url, boo l isDocumentBrowser);	76 virtual void OnDocumentComplete(IWebBrowser2* browser, const CString& url, boo l isDocumentBrowser);

79	77

80 static DWORD WINAPI TabThreadProc(LPVOID pParam);	78 static DWORD WINAPI TabThreadProc(LPVOID pParam);

81	79

82 #ifdef SUPPORT_FRAME_CACHING	80 #ifdef SUPPORT_FRAME_CACHING

83 void CacheFrame(const CString& url);	81 void CacheFrame(const CString& url);

84 bool IsFrameCached(const CString& url);	82 bool IsFrameCached(const CString& url);

85 void ClearFrameCache(const CString& domain="");	83 void ClearFrameCache(const CString& domain="");

86 #endif	84 #endif

87	85

88 };	86 };

89	87

90	88

91 #endif // _PLUGIN_TAB_BASE_H_	89 #endif // _PLUGIN_TAB_BASE_H_

LEFT	RIGHT