Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClientBase.cpp

Issue 11013110: Cleanup (Closed)
Patch Set: Whole cleanup + comments addressed Created July 23, 2013, 11:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginClientBase.cpp
===================================================================
--- a/src/plugin/PluginClientBase.cpp
+++ b/src/plugin/PluginClientBase.cpp
@@ -8,7 +8,6 @@
#include "PluginSettings.h"
#include "PluginSystem.h"
-#include "PluginHttpRequest.h"
#include "PluginMutex.h"
#include "PluginClass.h"
@@ -43,9 +42,7 @@
bool CPluginClientBase::IsValidDomain(const CString& domain)
{
- return domain != ABPDOMAIN &&
- domain != USERS_HOST &&
- domain != L"about:blank" &&
+ return domain != L"about:blank" &&
domain != L"about:tabs" &&
domain.Find(L"javascript:") != 0 &&
!domain.IsEmpty();
@@ -70,21 +67,6 @@
}
-void CPluginClientBase::SetLocalization()
-{
- CPluginSystem* system = CPluginSystem::GetInstance();
- CString browserLanguage = system->GetBrowserLanguage();
-
- CPluginSettings* settings = CPluginSettings::GetInstance();
- if (settings->IsMainProcess() && settings->IsMainThread() && !settings->Has(SETTING_LANGUAGE))
- {
- // TODO: We might want to set this to "en" if browserLanguage is not in filterLanguagesList
- settings->SetString(SETTING_LANGUAGE, browserLanguage);
- settings->Write();
- }
-}
-
-
void CPluginClientBase::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)
{
// Prevent circular references

Powered by Google App Engine
This is Rietveld