Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: chrome/content/ui/firstRun.js

Issue 11039060: first run page redesign (Closed)
Patch Set: improve after wladimirs code review Created Oct. 4, 2013, 4:50 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 (function() 20 (function()
21 { 21 {
22 var shade;
23 var scrollTimer;
24
25 // Load subscriptions for features 22 // Load subscriptions for features
26 var featureSubscriptions = [ 23 var featureSubscriptions = [
27 { 24 {
28 feature: "malware", 25 feature: "malware",
29 homepage: "http://malwaredomains.com/", 26 homepage: "http://malwaredomains.com/",
30 title: "Malware Domains", 27 title: "Malware Domains",
31 url: "https://easylist-downloads.adblockplus.org/malwaredomains_full.txt" 28 url: "https://easylist-downloads.adblockplus.org/malwaredomains_full.txt"
32 }, 29 },
33 { 30 {
34 feature: "social", 31 feature: "social",
35 homepage: "https://www.fanboy.co.nz/", 32 homepage: "https://www.fanboy.co.nz/",
36 title: "Fanboy's Social Blocking List", 33 title: "Fanboy's Social Blocking List",
37 url: "https://easylist-downloads.adblockplus.org/fanboy-social.txt" 34 url: "https://easylist-downloads.adblockplus.org/fanboy-social.txt"
38 }, 35 },
39 { 36 {
40 feature: "tracking", 37 feature: "tracking",
41 homepage: "https://easylist.adblockplus.org/", 38 homepage: "https://easylist.adblockplus.org/",
42 title: "EasyPrivacy", 39 title: "EasyPrivacy",
43 url: "https://easylist-downloads.adblockplus.org/easyprivacy.txt" 40 url: "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
44 } 41 }
45 ]; 42 ];
46 43
47 function onDOMLoaded() 44 function onDOMLoaded()
48 { 45 {
46 var locale = require("utils").Utils.appLocale;
47 document.documentElement.setAttribute("lang", locale);
48
49 // Set up URLs
50 var donateLink = E("donate");
51 donateLink.href = Utils.getDocLink("donate");
52
53 var contributors = E("contributors");
54 contributors.href = Utils.getDocLink("contributors");
55
56 setLinks("acceptableAdsExplanation", Utils.getDocLink("acceptable_ads_criter ia"), openFilters);
57 setLinks("share-headline", Utils.getDocLink("contribute"));
58
49 // Show warning if data corruption was detected 59 // Show warning if data corruption was detected
50 if (typeof backgroundPage != "undefined" && backgroundPage.seenDataCorruptio n) 60 if (typeof backgroundPage != "undefined" && backgroundPage.seenDataCorruptio n)
51 { 61 {
52 E("dataCorruptionWarning").removeAttribute("hidden"); 62 E("dataCorruptionWarning").removeAttribute("hidden");
53 setLinks("dataCorruptionWarning", Utils.getDocLink("knownIssuesChrome_filt erstorage")); 63 setLinks("dataCorruptionWarning", Utils.getDocLink("knownIssuesChrome_filt erstorage"));
54 } 64 }
55 65
56 // Set up URL
57 setLinks("acceptableAdsExplanation", Utils.getDocLink("acceptable_ads_criter ia"), openFilters);
58
59 shade = E("shade");
60 shade.addEventListener("mouseover", scrollPage, false);
61 shade.addEventListener("mouseout", stopScroll, false);
62
63 // Set up feature buttons linked to subscriptions 66 // Set up feature buttons linked to subscriptions
64 featureSubscriptions.forEach(setToggleSubscriptionButton); 67 featureSubscriptions.forEach(setToggleSubscriptionButton);
65 var filterListener = function(action) 68 var filterListener = function(action)
66 { 69 {
67 if (/^subscription\.(added|removed|disabled)$/.test(action)) 70 if (/^subscription\.(added|removed|disabled)$/.test(action))
68 { 71 {
69 for (var i = 0; i < featureSubscriptions.length; i++) 72 for (var i = 0; i < featureSubscriptions.length; i++)
70 { 73 {
71 var featureSubscription = featureSubscriptions[i]; 74 var featureSubscription = featureSubscriptions[i];
72 updateToggleButton(featureSubscription.feature, isSubscriptionEnabled( featureSubscription)); 75 updateToggleButton(featureSubscription.feature, isSubscriptionEnabled( featureSubscription));
73 } 76 }
74 } 77 }
75 } 78 }
76 FilterNotifier.addListener(filterListener); 79 FilterNotifier.addListener(filterListener);
77 window.addEventListener("unload", function(event) 80 window.addEventListener("unload", function(event)
78 { 81 {
79 FilterNotifier.removeListener(filterListener); 82 FilterNotifier.removeListener(filterListener);
80 }, false); 83 }, false);
81 84
82 window.addEventListener("resize", onWindowResize, false); 85 // You can click activate-feature or one of the icons to toggle the features area
83 document.addEventListener("scroll", onScroll, false); 86 E("activate-features").addEventListener("click", toggleFeature, false);
84 87 E("can-do-more-overview").addEventListener("click", toggleFeature, false);
85 onWindowResize();
86 88
87 initSocialLinks(); 89 initSocialLinks();
88 } 90 }
89 91
90 function onScroll() 92 function toggleFeature()
91 { 93 {
92 var currentHeight = document.documentElement.scrollTop + document.body.scrol lTop + document.documentElement.clientHeight; 94 var canDoMore = E("can-do-more");
93 shade.style.opacity = (document.documentElement.scrollHeight == currentHeigh t) ? "0.0" : "0.5"; 95 if (!canDoMore.classList.contains("expanded"))
94 } 96 {
95 97 canDoMore.classList.add("expanded");
96 function onWindowResize() 98 }
97 { 99 else if (canDoMore.classList.contains("expanded"))
98 onScroll(); 100 {
99 } 101 canDoMore.classList.remove("expanded");
100 102 }
Wladimir Palant 2013/10/05 09:15:59 Nit: One line of code is enough for the entire fun
101 function toggleTypoCorrectionEnabled()
102 {
103 Prefs.correctTypos = !Prefs.correctTypos;
104 } 103 }
105 104
106 function isSubscriptionEnabled(featureSubscription) 105 function isSubscriptionEnabled(featureSubscription)
107 { 106 {
108 return featureSubscription.url in FilterStorage.knownSubscriptions 107 return featureSubscription.url in FilterStorage.knownSubscriptions
109 && !Subscription.fromURL(featureSubscription.url).disabled; 108 && !Subscription.fromURL(featureSubscription.url).disabled;
110 } 109 }
111 110
112 function setToggleSubscriptionButton(featureSubscription) 111 function setToggleSubscriptionButton(featureSubscription)
113 { 112 {
(...skipping 11 matching lines...) Expand all
125 subscription.disabled = false; 124 subscription.disabled = false;
126 subscription.title = featureSubscription.title; 125 subscription.title = featureSubscription.title;
127 subscription.homepage = featureSubscription.homepage; 126 subscription.homepage = featureSubscription.homepage;
128 FilterStorage.addSubscription(subscription); 127 FilterStorage.addSubscription(subscription);
129 if (!subscription.lastDownload) 128 if (!subscription.lastDownload)
130 Synchronizer.execute(subscription); 129 Synchronizer.execute(subscription);
131 } 130 }
132 }, false); 131 }, false);
133 } 132 }
134 133
135 function scrollPage()
136 {
137 if (scrollTimer)
138 stopScroll();
139
140 scrollTimer = setInterval(function()
141 {
142 window.scrollBy(0, 5);
143 }, 20);
144 }
145
146 function stopScroll()
147 {
148 clearTimeout(scrollTimer);
149 scrollTimer = null;
150 }
151
152 function openSharePopup(url) 134 function openSharePopup(url)
153 { 135 {
154 var iframe = E("share-popup"); 136 var iframe = E("share-popup");
155 var glassPane = E("glass-pane"); 137 var glassPane = E("glass-pane");
156 var popupMessageReceived = false; 138 var popupMessageReceived = false;
157 139
158 var popupMessageListener = function(event) 140 var popupMessageListener = function(event)
159 { 141 {
160 var originFilter = Filter.fromText("||adblockplus.org^"); 142 var originFilter = Filter.fromText("||adblockplus.org^");
161 if (!originFilter.matches(event.origin, "OTHER", null, null)) 143 if (!originFilter.matches(event.origin, "OTHER", null, null))
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 { 200 {
219 event.preventDefault(); 201 event.preventDefault();
220 openSharePopup(Utils.getDocLink(event.target.id)); 202 openSharePopup(Utils.getDocLink(event.target.id));
221 } 203 }
222 } 204 }
223 205
224 function setLinks(id) 206 function setLinks(id)
225 { 207 {
226 var element = E(id); 208 var element = E(id);
227 if (!element) 209 if (!element)
210 {
228 return; 211 return;
229 212 }
213
230 var links = element.getElementsByTagName("a"); 214 var links = element.getElementsByTagName("a");
215
231 for (var i = 0; i < links.length; i++) 216 for (var i = 0; i < links.length; i++)
232 { 217 {
233 if (typeof arguments[i + 1] == "string") 218 if (typeof arguments[i + 1] == "string")
234 { 219 {
235 links[i].href = arguments[i + 1]; 220 links[i].href = arguments[i + 1];
236 links[i].setAttribute("target", "_blank"); 221 links[i].setAttribute("target", "_blank");
237 } 222 }
238 else if (typeof arguments[i + 1] == "function") 223 else if (typeof arguments[i + 1] == "function")
239 { 224 {
240 links[i].href = "javascript:void(0);"; 225 links[i].href = "javascript:void(0);";
(...skipping 16 matching lines...) Expand all
257 { 242 {
258 var button = E("toggle-" + feature); 243 var button = E("toggle-" + feature);
259 if (isEnabled) 244 if (isEnabled)
260 button.classList.remove("off"); 245 button.classList.remove("off");
261 else 246 else
262 button.classList.add("off"); 247 button.classList.add("off");
263 } 248 }
264 249
265 document.addEventListener("DOMContentLoaded", onDOMLoaded, false); 250 document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
266 })(); 251 })();
OLDNEW

Powered by Google App Engine
This is Rietveld