chrome/content/ui/firstRun.html - Issue 11039060: first run page redesign

Side by Side Diff: chrome/content/ui/firstRun.html

Issue 11039060: first run page redesign (Closed)

Patch Set: Created July 15, 2013, 2:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 - This file is part of Adblock Plus <http://adblockplus.org/>,	3 - This file is part of Adblock Plus <http://adblockplus.org/>,

4 - Copyright (C) 2006-2013 Eyeo GmbH	4 - Copyright (C) 2006-2013 Eyeo GmbH

5 -	5 -

6 - Adblock Plus is free software: you can redistribute it and/or modify	6 - Adblock Plus is free software: you can redistribute it and/or modify

7 - it under the terms of the GNU General Public License version 3 as	7 - it under the terms of the GNU General Public License version 3 as

8 - published by the Free Software Foundation.	8 - published by the Free Software Foundation.

9 -	9 -

10 - Adblock Plus is distributed in the hope that it will be useful,	10 - Adblock Plus is distributed in the hope that it will be useful,

11 - but WITHOUT ANY WARRANTY; without even the implied warranty of	11 - but WITHOUT ANY WARRANTY; without even the implied warranty of

12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 - GNU General Public License for more details.	13 - GNU General Public License for more details.

14 -	14 -

15 - You should have received a copy of the GNU General Public License	15 - You should have received a copy of the GNU General Public License

16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

17 -->	17 -->

18	18

19 <html>	19 <html>

20 <head>	20 <head>

21 <title class="i18n_firstRun_title"></title>	21 <title class="i18n_firstRun_title"></title>

22 <meta charset="utf-8">	22 <meta charset="utf-8">

23 <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/>	23 <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/>

24 <script type="text/javascript" src="utils.js"></script>	24 <script type="text/javascript" src="utils.js"></script>

25 <script type="text/javascript" src="i18n.js"></script>	25 <script type="text/javascript" src="i18n.js"></script>

26 <script type="text/javascript" src="firstRun.js"></script>	26 <script type="text/javascript" src="firstRun.js"></script>

27 </head>	27 </head>

28 <body>	28 <body>

29 <div id="shade" class="arrow"></div>	29 <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hi dden="true"></p>
	Thomas Greiner 2013/07/15 17:37:01 Why did you move this? Why did you move this?
30 <div id="content">	30

31 <header>	31 <header>

	32 <img id="logo" src="/skin/abp-icon-big.png" alt="Adblock Plus">

32 <h1 id="title-main" class="i18n_firstRun_title"></h1>	33 <h1 id="title-main" class="i18n_firstRun_title"></h1>

33 </header>	34 </header>

34	35

35 <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hidden="true"></p>

36	36

37 <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplana tion"></p>	37 <section id="acceptable-ads">

	38 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2>

	39 <p class="i18n_firstRun_acceptableAdsExplanation"></p>

	40 </section>

38	41

39 <h2 id="features-title" class="i18n_firstRun_features"></h2>	42 <section id="can-do-more">

	43 <h2 class="i18n_firstRun_features"></h2>

	44

	45 <!-- Features Title -->

40	46

41 <ul id="features">	47 <div id="can-do-more-expanded">

42 <li id="feature-malware" class="feature">	48 <ul id="features">

43 <div class="feature-image"></div>	49 <li id="feature-malware" class="feature">

44 <div class="feature-description">	50 <img class="feature-image" src="/skin/features/malware.png">
	Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags. Use background-image instead of image tags.
45 <p class="feature-text">	51 <div class="feature-description">

46 <span class="i18n_firstRun_feature_malware feature-title"></span> <span class="i18n_firstRun_feature_malware_description"></span>	52 <h3 class="i18n_firstRun_feature_malware feature-title"></h3>

47 </p>	53 <span class="i18n_firstRun_feature_malware_description"></span>

48 </div>	54 </div>

49 <div id="toggle-malware" class="toggle">	55 <div id="toggle-malware" class="toggle">

50 <div class="i18n_firstRun_toggle_on toggle-on"></div>	56 <div class="i18n_firstRun_toggle_on toggle-on"></div>

51 <div class="toggle-blob"></div>	57 <div class="toggle-blob"></div>

52 <div class="i18n_firstRun_toggle_off toggle-off"></div>	58 <div class="i18n_firstRun_toggle_off toggle-off"></div>

53 </div>	59 </div>

	60 </li>

	61 <li id="feature-social" class="feature">

	62 <img class="feature-image" src="/skin/features/social.png">
	Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags. Use background-image instead of image tags.
	63 <div class="feature-description">

	64 <h3 class="i18n_firstRun_feature_social feature-title"></h3>

	65 <span class="i18n_firstRun_feature_social_description"></span>

	66 </div>

	67 <div id="toggle-social" class="toggle">

	68 <div class="i18n_firstRun_toggle_on toggle-on"></div>

	69 <div class="toggle-blob"></div>

	70 <div class="i18n_firstRun_toggle_off toggle-off"></div>

	71 </div>

	72 </li>

	73 <li id="feature-tracking" class="feature">

	74 <img class="feature-image" src="/skin/features/tracking.png"/>
	Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags. Use background-image instead of image tags.
	75 <div class="feature-description">

	76 <h3 class="i18n_firstRun_feature_tracking feature-title"></h3>

	77 <span class="i18n_firstRun_feature_tracking_description"></span>

	78 </div>

	79 <div id="toggle-tracking" class="toggle">

	80 <div class="i18n_firstRun_toggle_on toggle-on"></div>

	81 <div class="toggle-blob"></div>

	82 <div class="i18n_firstRun_toggle_off toggle-off"></div>

	83 </div>

	84 </li>

	85 </ul>

	86 </div>

	87

	88 <ul id="can-do-more-overview">

	89 <li id="feature-first">

	90 <img src="/skin/features/social.png">
	Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags. Use background-image instead of image tags.
	91 <h4 class="i18n_firstRun_feature_social"></h4>

54 </li>	92 </li>

55 <li id="feature-social" class="feature">	93 <li>

56 <div class="feature-image"></div>	94 <img src="/skin/features/tracking.png">
	Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags. Use background-image instead of image tags.
57 <div class="feature-description">	95 <h4 class="i18n_firstRun_feature_tracking"></h4>

58 <p class="feature-text">

59 <span class="i18n_firstRun_feature_social feature-title"></span> < span class="i18n_firstRun_feature_social_description"></span>

60 </p>

61 </div>

62 <div id="toggle-social" class="toggle">

63 <div class="i18n_firstRun_toggle_on toggle-on"></div>

64 <div class="toggle-blob"></div>

65 <div class="i18n_firstRun_toggle_off toggle-off"></div>

66 </div>

67 </li>	96 </li>

68 <li id="feature-tracking" class="feature">	97 <li>

69 <div class="feature-image"></div>	98 <img src="/skin/features/malware.png">
	Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags. Use background-image instead of image tags.
70 <div class="feature-description">	99 <h4 class="i18n_firstRun_feature_malware"></h4>

71 <p class="feature-text">

72 <span class="i18n_firstRun_feature_tracking feature-title"></span> <span class="i18n_firstRun_feature_tracking_description"></span>

73 </p>

74 </div>

75 <div id="toggle-tracking" class="toggle">

76 <div class="i18n_firstRun_toggle_on toggle-on"></div>

77 <div class="toggle-blob"></div>

78 <div class="i18n_firstRun_toggle_off toggle-off"></div>

79 </div>

80 </li>	100 </li>

81 </ul>	101 </ul>

	102 <div class="clearfix"></div>

	103

	104 <div id="activate-features" class="i18n_firstRun_feature_activate" status= "overview">
	Thomas Greiner 2013/07/15 17:37:01 This is not a standard attribute of DIV. Either us This is not a standard attribute of DIV. Either use class for this or replace it with data-status. Also don't forget to update the references to it in firstRun.js.
	105 </div>

	106

	107 </section>

82	108

83 <footer id="social">	109

84 <h1 class="i18n_firstRun_share"></h1>	110 <section id="share">

85 <ul>	111 <div id="text">

86 <li>	112 <h2 class="i18n_firstRun_please"></h2>

87 <a id="share-facebook" class="share-button" href="https://www.facebo ok.com/adblockplus" target="_blank" title="Share on Facebook" data-script="https ://facebook.com/plugins/like.php?"></a>	113 <a id="donate" href="" class="i18n_firstRun_donate" target="_blank"></a>
	Thomas Greiner 2013/07/15 17:37:01 Remove href="". If there is no URL associated with Remove href="". If there is no URL associated with it, it should not have an href attribute.
88 </li>	114 <h2 class="i18n_firstRun_or_tell"></h2>

89 <li>	115 </div>

90 <a id="share-twitter" class="share-button" href="https://twitter.com /adblockplus" target="_blank" title="Share on Twitter" data-script="https://plat form.twitter.com/widgets.js"></a>	116 <div id="share-buttons">

91 </li>	117 <a id="share-facebook" href="https://www.facebook.com/adblockplus" targe t="_blank" >
	Thomas Greiner 2013/07/15 17:37:01 No need for changing this. Instead of putting the No need for changing this. Instead of putting the image into the anchor tag, make it a background image of the anchor tag (as it was before).
92 <li>	118 <img src="/skin/social/facebook.png" alt="facebook" data-script="https ://facebook.com/plugins/like.php?">

93 <a id="share-gplus" class="share-button" href="https://www.google.co m/+AdblockPlus" target="_blank" title="Share on Google+" data-script="https://ap is.google.com/js/plusone.js"></a>	119 </a>

94 </li>	120 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_bl ank">

95 </ul>	121 <img src="/skin/social/twitter.png" alt="twitter" data-script="https:/ /platform.twitter.com/widgets.js">

96 </footer>	122 </a>

97 </div>	123 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target="_ blank">

	124 <img src="/skin/social/googleplus.png" alt="googple plus" data-script= "https://apis.google.com/js/plusone.js">

	125 </a>

	126 </div>

	127 <div class="clearfix"></div>

	128 </section>

	129

	130 <footer>
	Thomas Greiner 2013/07/15 17:37:01 Why does this still exist? If you don't want to us Why does this still exist? If you don't want to use a footer then remove it.
	131 <!-- <h1 class="i18n_firstRun_share"></h1> -->

	132

	133 </footer>

98	134

99 <div id="glass-pane">	135 <div id="glass-pane">

100 <iframe id="share-popup" scrolling="no"></iframe>	136 <iframe id="share-popup" scrolling="no"></iframe>

101 </div>	137 </div>

102 </body>	138 </body>

103 </html>	139 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')