Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: chrome/content/ui/firstRun.html

Issue 11039060: first run page redesign (Closed)
Left Patch Set: Created July 22, 2013, 7:55 a.m.
Right Patch Set: improve after wladimirs code review Created Oct. 4, 2013, 4:50 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « build.py ('k') | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <http://adblockplus.org/>, 3 - This file is part of Adblock Plus <http://adblockplus.org/>,
4 - Copyright (C) 2006-2013 Eyeo GmbH 4 - Copyright (C) 2006-2013 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 15 matching lines...) Expand all
26 <script type="text/javascript" src="firstRun.js"></script> 26 <script type="text/javascript" src="firstRun.js"></script>
27 </head> 27 </head>
28 <body> 28 <body>
29 29
30 30
31 <header> 31 <header>
32 <div id="logo"></div> 32 <div id="logo"></div>
33 <h1 id="title-main" class="i18n_firstRun_title"></h1> 33 <h1 id="title-main" class="i18n_firstRun_title"></h1>
34 </header> 34 </header>
35 35
36 <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hi dden="true"></p> 36 <section id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarni ng" hidden="true"></section>
Thomas Greiner 2013/07/26 14:22:55 Change to <section>.
37 37
38 38
39 <section id="acceptable-ads"> 39 <section id="acceptable-ads">
40 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> 40 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2>
41 <p class="i18n_firstRun_acceptableAdsExplanation"></p> 41 <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplana tion"></p>
Thomas Greiner 2013/07/26 14:22:55 Links inside the text are not set.
42 </section> 42 </section>
43 43
44 <section id="can-do-more"> 44 <section id="can-do-more">
45 <h2 class="i18n_firstRun_features"></h2> 45 <h2 class="i18n_firstRun_features"></h2>
46 46
47 <ul id="can-do-more-overview"> 47 <ul id="can-do-more-overview">
48 <li id="feature-first"> 48 <li id="feature-first">
49 <div id="feature-malware-image"></div> 49 <div class="feature-malware-image"></div>
Thomas Greiner 2013/07/26 14:22:55 This ID is not unique. If you want a style to appl
50 <h4 class="i18n_firstRun_feature_malware"></h4> 50 <h4 class="i18n_firstRun_feature_malware"></h4>
51 </li> 51 </li>
52 <li> 52 <li>
53 <div id="feature-social-image"></div> 53 <div class="feature-social-image"></div>
Thomas Greiner 2013/07/26 14:22:55 This ID is not unique. If you want a style to appl
54 <h4 class="i18n_firstRun_feature_social"></h4> 54 <h4 class="i18n_firstRun_feature_social"></h4>
55 </li> 55 </li>
56 <li> 56 <li>
57 <div id="feature-tracking-image"></div> 57 <div class="feature-tracking-image"></div>
Thomas Greiner 2013/07/26 14:22:55 This ID is not unique. If you want a style to appl
58 <h4 class="i18n_firstRun_feature_tracking"></h4> 58 <h4 class="i18n_firstRun_feature_tracking"></h4>
59 </li> 59 </li>
60 </ul> 60 </ul>
61 61
62 <div id="can-do-more-expanded"> 62 <div id="can-do-more-expanded">
63 <ul id="features"> 63 <ul id="features">
64 <li id="feature-malware" class="feature"> 64 <li id="feature-malware" class="feature">
65 <div id="feature-malware-image" class="feature-image"></div> 65 <div class="feature-image feature-malware-image"></div>
66 <div class="feature-description"> 66 <div class="feature-description">
67 <div class="feature-description-textblock"> 67 <div class="feature-description-textblock">
68 <h3 class="i18n_firstRun_feature_malware feature-title"></h3> 68 <h3 class="i18n_firstRun_feature_malware feature-title"></h3>
69 <span class="i18n_firstRun_feature_malware_description"></span> 69 <span class="i18n_firstRun_feature_malware_description"></span>
70 </div> 70 </div>
71 <div id="toggle-malware" class="toggle"> 71 <div id="toggle-malware" class="toggle">
72 <div class="i18n_firstRun_toggle_on toggle-on"></div> 72 <div class="i18n_firstRun_toggle_on toggle-on"></div>
73 <div class="toggle-blob"></div> 73 <div class="toggle-blob"></div>
74 <div class="i18n_firstRun_toggle_off toggle-off"></div> 74 <div class="i18n_firstRun_toggle_off toggle-off"></div>
75 </div> 75 </div>
76 </div> 76 </div>
77 77
78 </li> 78 </li>
79 <li id="feature-social" class="feature"> 79 <li id="feature-social" class="feature">
80 <div id="feature-social-image" class="feature-image"></div> 80 <div class="feature-image feature-social-image"></div>
81 <div class="feature-description"> 81 <div class="feature-description">
82 <div class="feature-description-textblock"> 82 <div class="feature-description-textblock">
83 <h3 class="i18n_firstRun_feature_social feature-title"></h3> 83 <h3 class="i18n_firstRun_feature_social feature-title"></h3>
84 <span class="i18n_firstRun_feature_social_description"></span> 84 <span class="i18n_firstRun_feature_social_description"></span>
85 </div> 85 </div>
86 <div id="toggle-social" class="toggle"> 86 <div id="toggle-social" class="toggle">
87 <div class="i18n_firstRun_toggle_on toggle-on"></div> 87 <div class="i18n_firstRun_toggle_on toggle-on"></div>
88 <div class="toggle-blob"></div> 88 <div class="toggle-blob"></div>
89 <div class="i18n_firstRun_toggle_off toggle-off"></div> 89 <div class="i18n_firstRun_toggle_off toggle-off"></div>
90 </div> 90 </div>
91 </div> 91 </div>
92 </li> 92 </li>
93 93
94 <li id="feature-tracking" class="feature"> 94 <li id="feature-tracking" class="feature">
95 <div id="feature-tracking-image" class="feature-image" src="/skin/fe atures/tracking.png"/></div> 95 <div class="feature-image feature-tracking-image"></div>
96 <div class="feature-description"> 96 <div class="feature-description">
97 <div class="feature-description-textblock"> 97 <div class="feature-description-textblock">
98 <h3 class="i18n_firstRun_feature_tracking feature-title"></h3> 98 <h3 class="i18n_firstRun_feature_tracking feature-title"></h3>
99 <span class="i18n_firstRun_feature_tracking_description"></spa n> 99 <span class="i18n_firstRun_feature_tracking_description"></spa n>
100 </div> 100 </div>
101 <div id="toggle-tracking" class="toggle"> 101 <div id="toggle-tracking" class="toggle">
102 <div class="i18n_firstRun_toggle_on toggle-on"></div> 102 <div class="i18n_firstRun_toggle_on toggle-on"></div>
103 <div class="toggle-blob"></div> 103 <div class="toggle-blob"></div>
104 <div class="i18n_firstRun_toggle_off toggle-off"></div> 104 <div class="i18n_firstRun_toggle_off toggle-off"></div>
105 </div> 105 </div>
106 </div> 106 </div>
107 </li> 107 </li>
108 108
109 </ul> 109 </ul>
110
110 </div> 111 </div>
111 <div class="clearfix"></div> 112
112 <div id="activate-features" class="i18n_firstRun_feature_activate" data-st atus="overview"> 113
Thomas Greiner 2013/07/26 14:22:55 If you put the status as a class name in <body> in
114 <div id="activate-features" class="overview" data-status="overview">
115 <div class="arrow"></div>
116 <a id="activate-features-label">
117 <span id="label-show-expanded" class="i18n_firstRun_feature_show_expan ded"></span>
118 <span id="label-show-overview" class="i18n_firstRun_feature_show_overv iew hide"></span>
119 </a>
120
121 <div class="arrow"></div>
113 </div> 122 </div>
114 </section> 123 </section>
115 124
116 <section id="share"> 125 <section id="share">
126 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2>
127
117 <div id="donate-block"> 128 <div id="donate-block">
118 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a> 129 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a>
130 <span id="donate-label" class="i18n_firstRun_donate_label"></span>
119 </div> 131 </div>
120 132
121 <div id="share-block"> 133 <div id="share-block">
122 <h2 class="i18n_firstRun_or_tell"></h2> 134 <div id="share-general" class="share-buttons">
123 <div id="share-buttons">
124 <a id="share-facebook" href="https://www.facebook.com/adblockplus" tar get="_blank" data-script="https://facebook.com/plugins/like.php?"> 135 <a id="share-facebook" href="https://www.facebook.com/adblockplus" tar get="_blank" data-script="https://facebook.com/plugins/like.php?">
125 </a> 136 </a>
126 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_ blank" data-script="https://platform.twitter.com/widgets.js"> 137 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_ blank" data-script="https://platform.twitter.com/widgets.js">
127 </a> 138 </a>
128 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target= "_blank" data-script="https://apis.google.com/js/plusone.js"> 139 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target= "_blank" data-script="https://apis.google.com/js/plusone.js">
129 </a> 140 </a>
130 </div> 141 </div>
142
143 <!-- Chinese social networks -->
144 <div id="share-chinese" class="share-buttons">
145 <a id="share-renren" href="http://www.renren.com/601651969" target="_b lank">
146 </a>
147 <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_bl ank">
148 </a>
149 </div>
150 <span class="i18n_firstRun_share"></span>
131 </div> 151 </div>
132 <div class="clearfix"></div> 152
133 </section> 153 </section>
134 154
155 <footer>
156 <a id="contributors" class="i18n_firstRun_contributor_credits"></a>
157 </footer>
158
159
135 <div id="glass-pane"> 160 <div id="glass-pane">
136 <iframe id="share-popup" scrolling="no"></iframe> 161 <iframe id="share-popup" scrolling="no"></iframe>
137 </div> 162 </div>
138 </body> 163 </body>
139 </html> 164 </html>
LEFTRIGHT
« build.py ('k') | chrome/content/ui/firstRun.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld