Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: chrome/content/ui/firstRun.html

Issue 11039060: first run page redesign (Closed)
Left Patch Set: Created July 15, 2013, 2:19 p.m.
Right Patch Set: improve after wladimirs code review Created Oct. 4, 2013, 4:50 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « build.py ('k') | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <http://adblockplus.org/>, 3 - This file is part of Adblock Plus <http://adblockplus.org/>,
4 - Copyright (C) 2006-2013 Eyeo GmbH 4 - Copyright (C) 2006-2013 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
11 - but WITHOUT ANY WARRANTY; without even the implied warranty of 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of
12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 - GNU General Public License for more details. 13 - GNU General Public License for more details.
14 - 14 -
15 - You should have received a copy of the GNU General Public License 15 - You should have received a copy of the GNU General Public License
16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17 --> 17 -->
18 18
19 <html> 19 <html>
20 <head> 20 <head>
21 <title class="i18n_firstRun_title"></title> 21 <title class="i18n_firstRun_title"></title>
22 <meta charset="utf-8"> 22 <meta charset="utf-8">
23 <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/> 23 <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/>
24 <script type="text/javascript" src="utils.js"></script> 24 <script type="text/javascript" src="utils.js"></script>
25 <script type="text/javascript" src="i18n.js"></script> 25 <script type="text/javascript" src="i18n.js"></script>
26 <script type="text/javascript" src="firstRun.js"></script> 26 <script type="text/javascript" src="firstRun.js"></script>
27 </head> 27 </head>
28 <body> 28 <body>
29 <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hi dden="true"></p> 29
Thomas Greiner 2013/07/15 17:37:01 Why did you move this?
30 30
31 <header> 31 <header>
32 <img id="logo" src="/skin/abp-icon-big.png" alt="Adblock Plus"> 32 <div id="logo"></div>
33 <h1 id="title-main" class="i18n_firstRun_title"></h1> 33 <h1 id="title-main" class="i18n_firstRun_title"></h1>
34 </header> 34 </header>
35
36 <section id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarni ng" hidden="true"></section>
35 37
36 38
37 <section id="acceptable-ads"> 39 <section id="acceptable-ads">
38 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> 40 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2>
39 <p class="i18n_firstRun_acceptableAdsExplanation"></p> 41 <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplana tion"></p>
40 </section> 42 </section>
41 43
42 <section id="can-do-more"> 44 <section id="can-do-more">
43 <h2 class="i18n_firstRun_features"></h2> 45 <h2 class="i18n_firstRun_features"></h2>
44 46
45 <!-- Features Title --> 47 <ul id="can-do-more-overview">
48 <li id="feature-first">
49 <div class="feature-malware-image"></div>
50 <h4 class="i18n_firstRun_feature_malware"></h4>
51 </li>
52 <li>
53 <div class="feature-social-image"></div>
54 <h4 class="i18n_firstRun_feature_social"></h4>
55 </li>
56 <li>
57 <div class="feature-tracking-image"></div>
58 <h4 class="i18n_firstRun_feature_tracking"></h4>
59 </li>
60 </ul>
46 61
47 <div id="can-do-more-expanded"> 62 <div id="can-do-more-expanded">
48 <ul id="features"> 63 <ul id="features">
49 <li id="feature-malware" class="feature"> 64 <li id="feature-malware" class="feature">
50 <img class="feature-image" src="/skin/features/malware.png"> 65 <div class="feature-image feature-malware-image"></div>
Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags.
51 <div class="feature-description"> 66 <div class="feature-description">
52 <h3 class="i18n_firstRun_feature_malware feature-title"></h3> 67 <div class="feature-description-textblock">
53 <span class="i18n_firstRun_feature_malware_description"></span> 68 <h3 class="i18n_firstRun_feature_malware feature-title"></h3>
69 <span class="i18n_firstRun_feature_malware_description"></span>
70 </div>
71 <div id="toggle-malware" class="toggle">
72 <div class="i18n_firstRun_toggle_on toggle-on"></div>
73 <div class="toggle-blob"></div>
74 <div class="i18n_firstRun_toggle_off toggle-off"></div>
75 </div>
54 </div> 76 </div>
55 <div id="toggle-malware" class="toggle"> 77
56 <div class="i18n_firstRun_toggle_on toggle-on"></div> 78 </li>
57 <div class="toggle-blob"></div> 79 <li id="feature-social" class="feature">
58 <div class="i18n_firstRun_toggle_off toggle-off"></div> 80 <div class="feature-image feature-social-image"></div>
81 <div class="feature-description">
82 <div class="feature-description-textblock">
83 <h3 class="i18n_firstRun_feature_social feature-title"></h3>
84 <span class="i18n_firstRun_feature_social_description"></span>
85 </div>
86 <div id="toggle-social" class="toggle">
87 <div class="i18n_firstRun_toggle_on toggle-on"></div>
88 <div class="toggle-blob"></div>
89 <div class="i18n_firstRun_toggle_off toggle-off"></div>
90 </div>
59 </div> 91 </div>
60 </li> 92 </li>
61 <li id="feature-social" class="feature"> 93
62 <img class="feature-image" src="/skin/features/social.png"> 94 <li id="feature-tracking" class="feature">
Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags.
95 <div class="feature-image feature-tracking-image"></div>
63 <div class="feature-description"> 96 <div class="feature-description">
64 <h3 class="i18n_firstRun_feature_social feature-title"></h3> 97 <div class="feature-description-textblock">
65 <span class="i18n_firstRun_feature_social_description"></span> 98 <h3 class="i18n_firstRun_feature_tracking feature-title"></h3>
66 </div> 99 <span class="i18n_firstRun_feature_tracking_description"></spa n>
67 <div id="toggle-social" class="toggle"> 100 </div>
68 <div class="i18n_firstRun_toggle_on toggle-on"></div> 101 <div id="toggle-tracking" class="toggle">
69 <div class="toggle-blob"></div> 102 <div class="i18n_firstRun_toggle_on toggle-on"></div>
70 <div class="i18n_firstRun_toggle_off toggle-off"></div> 103 <div class="toggle-blob"></div>
104 <div class="i18n_firstRun_toggle_off toggle-off"></div>
105 </div>
71 </div> 106 </div>
72 </li> 107 </li>
73 <li id="feature-tracking" class="feature"> 108
74 <img class="feature-image" src="/skin/features/tracking.png"/>
Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags.
75 <div class="feature-description">
76 <h3 class="i18n_firstRun_feature_tracking feature-title"></h3>
77 <span class="i18n_firstRun_feature_tracking_description"></span>
78 </div>
79 <div id="toggle-tracking" class="toggle">
80 <div class="i18n_firstRun_toggle_on toggle-on"></div>
81 <div class="toggle-blob"></div>
82 <div class="i18n_firstRun_toggle_off toggle-off"></div>
83 </div>
84 </li>
85 </ul> 109 </ul>
110
111 </div>
112
113
114 <div id="activate-features" class="overview" data-status="overview">
115 <div class="arrow"></div>
116 <a id="activate-features-label">
117 <span id="label-show-expanded" class="i18n_firstRun_feature_show_expan ded"></span>
118 <span id="label-show-overview" class="i18n_firstRun_feature_show_overv iew hide"></span>
119 </a>
120
121 <div class="arrow"></div>
122 </div>
123 </section>
124
125 <section id="share">
126 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2>
127
128 <div id="donate-block">
129 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a>
130 <span id="donate-label" class="i18n_firstRun_donate_label"></span>
86 </div> 131 </div>
87 132
88 <ul id="can-do-more-overview"> 133 <div id="share-block">
89 <li id="feature-first"> 134 <div id="share-general" class="share-buttons">
90 <img src="/skin/features/social.png"> 135 <a id="share-facebook" href="https://www.facebook.com/adblockplus" tar get="_blank" data-script="https://facebook.com/plugins/like.php?">
Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags.
91 <h4 class="i18n_firstRun_feature_social"></h4> 136 </a>
92 </li> 137 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_ blank" data-script="https://platform.twitter.com/widgets.js">
93 <li> 138 </a>
94 <img src="/skin/features/tracking.png"> 139 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target= "_blank" data-script="https://apis.google.com/js/plusone.js">
Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags.
95 <h4 class="i18n_firstRun_feature_tracking"></h4> 140 </a>
96 </li> 141 </div>
97 <li>
98 <img src="/skin/features/malware.png">
Thomas Greiner 2013/07/15 17:37:01 Use background-image instead of image tags.
99 <h4 class="i18n_firstRun_feature_malware"></h4>
100 </li>
101 </ul>
102 <div class="clearfix"></div>
103 142
104 <div id="activate-features" class="i18n_firstRun_feature_activate" status= "overview"> 143 <!-- Chinese social networks -->
Thomas Greiner 2013/07/15 17:37:01 This is not a standard attribute of DIV. Either us
105 </div> 144 <div id="share-chinese" class="share-buttons">
145 <a id="share-renren" href="http://www.renren.com/601651969" target="_b lank">
146 </a>
147 <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_bl ank">
148 </a>
149 </div>
150 <span class="i18n_firstRun_share"></span>
151 </div>
152
153 </section>
106 154
107 </section>
108
109
110 <section id="share">
111 <div id="text">
112 <h2 class="i18n_firstRun_please"></h2>
113 <a id="donate" href="" class="i18n_firstRun_donate" target="_blank"></a>
Thomas Greiner 2013/07/15 17:37:01 Remove href="". If there is no URL associated with
114 <h2 class="i18n_firstRun_or_tell"></h2>
115 </div>
116 <div id="share-buttons">
117 <a id="share-facebook" href="https://www.facebook.com/adblockplus" targe t="_blank" >
Thomas Greiner 2013/07/15 17:37:01 No need for changing this. Instead of putting the
118 <img src="/skin/social/facebook.png" alt="facebook" data-script="https ://facebook.com/plugins/like.php?">
119 </a>
120 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_bl ank">
121 <img src="/skin/social/twitter.png" alt="twitter" data-script="https:/ /platform.twitter.com/widgets.js">
122 </a>
123 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target="_ blank">
124 <img src="/skin/social/googleplus.png" alt="googple plus" data-script= "https://apis.google.com/js/plusone.js">
125 </a>
126 </div>
127 <div class="clearfix"></div>
128 </section>
129
130 <footer> 155 <footer>
Thomas Greiner 2013/07/15 17:37:01 Why does this still exist? If you don't want to us
131 <!-- <h1 class="i18n_firstRun_share"></h1> --> 156 <a id="contributors" class="i18n_firstRun_contributor_credits"></a>
132
133 </footer> 157 </footer>
134 158
159
135 <div id="glass-pane"> 160 <div id="glass-pane">
136 <iframe id="share-popup" scrolling="no"></iframe> 161 <iframe id="share-popup" scrolling="no"></iframe>
137 </div> 162 </div>
138 </body> 163 </body>
139 </html> 164 </html>
LEFTRIGHT
« build.py ('k') | chrome/content/ui/firstRun.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld