first run page redesign

chrome/content/ui/firstRun.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
     {
       feature: "tracking",
       homepage: "https://easylist.adblockplus.org/",
       title: "EasyPrivacy",
       url: "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
     }
   ];
 
   function onDOMLoaded()
   {
+    var locale = require("utils").Utils.appLocale;
+    document.documentElement.setAttribute("lang", locale);
+    
+    // Set up URLs
     var donateLink = E("donate");
     donateLink.href = Utils.getDocLink("donate");
     
-    // Set up URL
+    var contributors = E("contributors");
+    contributors.href = Utils.getDocLink("contributors");
+    
     setLinks("acceptableAdsExplanation", Utils.getDocLink("acceptable_ads_criteria"), openFilters);
     setLinks("share-headline", Utils.getDocLink("contribute"));
     
     // Show warning if data corruption was detected
     if (typeof backgroundPage != "undefined" && backgroundPage.seenDataCorruption)
     {
       E("dataCorruptionWarning").removeAttribute("hidden");
       setLinks("dataCorruptionWarning", Utils.getDocLink("knownIssuesChrome_filterstorage"));
     }
 
@@ skipping 10 matching lines @@
         }
       }
     }
     FilterNotifier.addListener(filterListener);
     window.addEventListener("unload", function(event)
     {
       FilterNotifier.removeListener(filterListener);
     }, false);
 
     // You can click activate-feature or one of the icons to toggle the features area
-    E("activate-features").addEventListener("click", showFeature, false);
-    E("can-do-more-overview").addEventListener("click", showFeature, false);
+    E("activate-features").addEventListener("click", toggleFeature, false);
+    E("can-do-more-overview").addEventListener("click", toggleFeature, false);
 
     initSocialLinks();
   }
   
-  function showFeature()
+  function toggleFeature()
   { 
-    var activateFeatures = E("activate-features");
-    var canDoMoreOverview = E("can-do-more-overview");
-    var canDoMoreExpanded = E("can-do-more-expanded");
-    var activateFeaturesLabel = E("activate-features-label");
-    
-    if (activateFeatures.getAttribute("class") == "overview")

[Thomas Greiner, 2013/08/22 10:42:12]

You can use classList.contains instead.

-    {   
-      canDoMoreOverview.classList.remove("fade-in");
-      canDoMoreOverview.classList.add("fade-out");
-      activateFeatures.classList.remove("overview");
-      activateFeatures.classList.add("expanded");

[Thomas Greiner, 2013/08/22 10:42:12]

Why don't you simply add the class "expanded" to #can-do-more when it's expanded
and remove it when it's not?

By doing that you should be able to get rid of many of those classList.add and
classList.remove calls on #can-do-more-expanded, #can-do-more-overview and
#activate-features.

-            
-      
-      /* Cross Browser Text change */
-      if ((activateFeaturesLabel.textContent) && (typeof (activateFeaturesLabel.textContent) != "undefined")) 

[Thomas Greiner, 2013/08/22 10:42:12]

No need for checking it twice. Checking
if ("textContent" in activateFeaturesLabel)
should be sufficient.

Doesn't require to be annotated.

-      {
-        activateFeaturesLabel.textContent = "show overview again";

[Thomas Greiner, 2013/08/22 10:42:12]

Should be translatable.

-      } else 
-      {
-        activateFeaturesLabel.innerText = "show overview again";

[Thomas Greiner, 2013/08/22 10:42:12]

Should be translatable.

-      }
-      activateFeatures.setAttribute("data-status","expanded");
-      
-      setTimeout(function()
-      {
-        canDoMoreOverview.classList.add("hide");
-        canDoMoreExpanded.classList.add("show");
-        canDoMoreExpanded.classList.add("can-do-more-expanded-higher");
-      },500);
-      
-      /* Next timeout has to be done because of an js bug. 
-       * If you set "display: block" and "opacity: 1" 
-       * at the same time the content would be shown 
-       * directly without any transition. 
-       * With the following timeout the opacity 
-       * transition works correctly 
-       */   
-      setTimeout(function()
-      {
-        canDoMoreExpanded.classList.add("fade-in");
-      },520);
-    }
-    else if (activateFeatures.getAttribute("class") == "expanded")
-    {
-      canDoMoreExpanded.classList.remove("fade-in");
-      activateFeatures.classList.remove("expanded");
-      activateFeatures.classList.add("overview");
-      
-      /* Cross Browser Text change */
-      if ((activateFeaturesLabel.textContent) && (typeof (activateFeaturesLabel.textContent) != "undefined")) 

[Thomas Greiner, 2013/08/22 10:42:12]

No need for checking it twice. Checking
if ("textContent" in activateFeaturesLabel)
should be sufficient.

Doesn't require to be annotated.

-      {
-        activateFeaturesLabel.textContent = "activate features";

[Thomas Greiner, 2013/08/22 10:42:12]

Should be translatable.

-      } else 
-      {
-        activateFeaturesLabel.innerText = "activate features";

[Thomas Greiner, 2013/08/22 10:42:12]

Should be translatable.

-      }
-      activateFeatures.setAttribute("data-status","overview");
-      
-      setTimeout(function()
-      { 
-        canDoMoreExpanded.classList.remove("show");
-        canDoMoreOverview.classList.remove("hide");
-      },500);
-        
-      setTimeout(function()
-      {
-        canDoMoreOverview.classList.add("fade-in");
-        canDoMoreOverview.classList.remove("fade-out");
-      },520);
+    var canDoMore = E("can-do-more");
+    if (!canDoMore.classList.contains("expanded"))
+    { 
+      canDoMore.classList.add("expanded");
+    }
+    else if (canDoMore.classList.contains("expanded"))
+    {
+      canDoMore.classList.remove("expanded");
     }

[Wladimir Palant, 2013/10/05 09:15:59]

Nit: One line of code is enough for the entire function now:

E("can-do-more").classList.toggle("expanded");

   }
 
   function isSubscriptionEnabled(featureSubscription)
   {
     return featureSubscription.url in FilterStorage.knownSubscriptions
       && !Subscription.fromURL(featureSubscription.url).disabled;
   }
 
   function setToggleSubscriptionButton(featureSubscription)
   {
     var feature = featureSubscription.feature;
 
     var element = E("toggle-" + feature);
     updateToggleButton(feature, isSubscriptionEnabled(featureSubscription));
     element.addEventListener("click", function(event)
     {
       var subscription = Subscription.fromURL(featureSubscription.url);
       if (isSubscriptionEnabled(featureSubscription))
         FilterStorage.removeSubscription(subscription);
       else
       {
         subscription.disabled = false;
         subscription.title = featureSubscription.title;
         subscription.homepage = featureSubscription.homepage;
         FilterStorage.addSubscription(subscription);
         if (!subscription.lastDownload)
           Synchronizer.execute(subscription);
       }
     }, false);
-  }
-
-  function scrollPage()
-  {
-    if (scrollTimer)
-      stopScroll();
-
-    scrollTimer = setInterval(function()
-    {
-      window.scrollBy(0, 5);
-    }, 20);
-  }
-
-  function stopScroll()
-  {
-    clearTimeout(scrollTimer);
-    scrollTimer = null;
   }
 
   function openSharePopup(url)
   {
     var iframe = E("share-popup");
     var glassPane = E("glass-pane");
     var popupMessageReceived = false;
 
     var popupMessageListener = function(event)
     {
@@ skipping 100 matching lines @@
   {
     var button = E("toggle-" + feature);
     if (isEnabled)
       button.classList.remove("off");
     else
       button.classList.add("off");
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();