Unified Diff: chrome/content/ui/firstRun.html
Issue 11039060:
first run page redesign (Closed)
Patch Set:
Created July 15, 2013, 2:19 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
chrome/content/ui/firstRun.js » ('j')
|
chrome/content/ui/firstRun.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/content/ui/firstRun.html |
| =================================================================== |
| --- a/chrome/content/ui/firstRun.html |
| +++ b/chrome/content/ui/firstRun.html |
| @@ -1,103 +1,139 @@ |
| -<!DOCTYPE html> |
| -<!-- |
| - - This file is part of Adblock Plus <http://adblockplus.org/>, |
| - - Copyright (C) 2006-2013 Eyeo GmbH |
| - - |
| - - Adblock Plus is free software: you can redistribute it and/or modify |
| - - it under the terms of the GNU General Public License version 3 as |
| - - published by the Free Software Foundation. |
| - - |
| - - Adblock Plus is distributed in the hope that it will be useful, |
| - - but WITHOUT ANY WARRANTY; without even the implied warranty of |
| - - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| - - GNU General Public License for more details. |
| - - |
| - - You should have received a copy of the GNU General Public License |
| - - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| - --> |
| - |
| -<html> |
| - <head> |
| - <title class="i18n_firstRun_title"></title> |
| - <meta charset="utf-8"> |
| - <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/> |
| - <script type="text/javascript" src="utils.js"></script> |
| - <script type="text/javascript" src="i18n.js"></script> |
| - <script type="text/javascript" src="firstRun.js"></script> |
| - </head> |
| - <body> |
| - <div id="shade" class="arrow"></div> |
| - <div id="content"> |
| - <header> |
| - <h1 id="title-main" class="i18n_firstRun_title"></h1> |
| - </header> |
| - |
| - <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hidden="true"></p> |
| - |
| - <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplanation"></p> |
| - |
| - <h2 id="features-title" class="i18n_firstRun_features"></h2> |
| - |
| - <ul id="features"> |
| - <li id="feature-malware" class="feature"> |
| - <div class="feature-image"></div> |
| - <div class="feature-description"> |
| - <p class="feature-text"> |
| - <span class="i18n_firstRun_feature_malware feature-title"></span> <span class="i18n_firstRun_feature_malware_description"></span> |
| - </p> |
| - </div> |
| - <div id="toggle-malware" class="toggle"> |
| - <div class="i18n_firstRun_toggle_on toggle-on"></div> |
| - <div class="toggle-blob"></div> |
| - <div class="i18n_firstRun_toggle_off toggle-off"></div> |
| - </div> |
| - </li> |
| - <li id="feature-social" class="feature"> |
| - <div class="feature-image"></div> |
| - <div class="feature-description"> |
| - <p class="feature-text"> |
| - <span class="i18n_firstRun_feature_social feature-title"></span> <span class="i18n_firstRun_feature_social_description"></span> |
| - </p> |
| - </div> |
| - <div id="toggle-social" class="toggle"> |
| - <div class="i18n_firstRun_toggle_on toggle-on"></div> |
| - <div class="toggle-blob"></div> |
| - <div class="i18n_firstRun_toggle_off toggle-off"></div> |
| - </div> |
| - </li> |
| - <li id="feature-tracking" class="feature"> |
| - <div class="feature-image"></div> |
| - <div class="feature-description"> |
| - <p class="feature-text"> |
| - <span class="i18n_firstRun_feature_tracking feature-title"></span> <span class="i18n_firstRun_feature_tracking_description"></span> |
| - </p> |
| - </div> |
| - <div id="toggle-tracking" class="toggle"> |
| - <div class="i18n_firstRun_toggle_on toggle-on"></div> |
| - <div class="toggle-blob"></div> |
| - <div class="i18n_firstRun_toggle_off toggle-off"></div> |
| - </div> |
| - </li> |
| - </ul> |
| - |
| - <footer id="social"> |
| - <h1 class="i18n_firstRun_share"></h1> |
| - <ul> |
| - <li> |
| - <a id="share-facebook" class="share-button" href="https://www.facebook.com/adblockplus" target="_blank" title="Share on Facebook" data-script="https://facebook.com/plugins/like.php?"></a> |
| - </li> |
| - <li> |
| - <a id="share-twitter" class="share-button" href="https://twitter.com/adblockplus" target="_blank" title="Share on Twitter" data-script="https://platform.twitter.com/widgets.js"></a> |
| - </li> |
| - <li> |
| - <a id="share-gplus" class="share-button" href="https://www.google.com/+AdblockPlus" target="_blank" title="Share on Google+" data-script="https://apis.google.com/js/plusone.js"></a> |
| - </li> |
| - </ul> |
| - </footer> |
| - </div> |
| - |
| - <div id="glass-pane"> |
| - <iframe id="share-popup" scrolling="no"></iframe> |
| - </div> |
| - </body> |
| -</html> |
| +<!DOCTYPE html> |
| +<!-- |
| + - This file is part of Adblock Plus <http://adblockplus.org/>, |
| + - Copyright (C) 2006-2013 Eyeo GmbH |
| + - |
| + - Adblock Plus is free software: you can redistribute it and/or modify |
| + - it under the terms of the GNU General Public License version 3 as |
| + - published by the Free Software Foundation. |
| + - |
| + - Adblock Plus is distributed in the hope that it will be useful, |
| + - but WITHOUT ANY WARRANTY; without even the implied warranty of |
| + - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| + - GNU General Public License for more details. |
| + - |
| + - You should have received a copy of the GNU General Public License |
| + - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| + --> |
| + |
| +<html> |
| + <head> |
| + <title class="i18n_firstRun_title"></title> |
| + <meta charset="utf-8"> |
| + <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/> |
| + <script type="text/javascript" src="utils.js"></script> |
| + <script type="text/javascript" src="i18n.js"></script> |
| + <script type="text/javascript" src="firstRun.js"></script> |
| + </head> |
| + <body> |
| + <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hidden="true"></p> |
|
Thomas Greiner
2013/07/15 17:37:01
Why did you move this?
|
| + |
| + <header> |
| + <img id="logo" src="/skin/abp-icon-big.png" alt="Adblock Plus"> |
| + <h1 id="title-main" class="i18n_firstRun_title"></h1> |
| + </header> |
| + |
| + |
| + <section id="acceptable-ads"> |
| + <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> |
| + <p class="i18n_firstRun_acceptableAdsExplanation"></p> |
| + </section> |
| + |
| + <section id="can-do-more"> |
| + <h2 class="i18n_firstRun_features"></h2> |
| + |
| + <!-- Features Title --> |
| + |
| + <div id="can-do-more-expanded"> |
| + <ul id="features"> |
| + <li id="feature-malware" class="feature"> |
| + <img class="feature-image" src="/skin/features/malware.png"> |
|
Thomas Greiner
2013/07/15 17:37:01
Use background-image instead of image tags.
|
| + <div class="feature-description"> |
| + <h3 class="i18n_firstRun_feature_malware feature-title"></h3> |
| + <span class="i18n_firstRun_feature_malware_description"></span> |
| + </div> |
| + <div id="toggle-malware" class="toggle"> |
| + <div class="i18n_firstRun_toggle_on toggle-on"></div> |
| + <div class="toggle-blob"></div> |
| + <div class="i18n_firstRun_toggle_off toggle-off"></div> |
| + </div> |
| + </li> |
| + <li id="feature-social" class="feature"> |
| + <img class="feature-image" src="/skin/features/social.png"> |
|
Thomas Greiner
2013/07/15 17:37:01
Use background-image instead of image tags.
|
| + <div class="feature-description"> |
| + <h3 class="i18n_firstRun_feature_social feature-title"></h3> |
| + <span class="i18n_firstRun_feature_social_description"></span> |
| + </div> |
| + <div id="toggle-social" class="toggle"> |
| + <div class="i18n_firstRun_toggle_on toggle-on"></div> |
| + <div class="toggle-blob"></div> |
| + <div class="i18n_firstRun_toggle_off toggle-off"></div> |
| + </div> |
| + </li> |
| + <li id="feature-tracking" class="feature"> |
| + <img class="feature-image" src="/skin/features/tracking.png"/> |
|
Thomas Greiner
2013/07/15 17:37:01
Use background-image instead of image tags.
|
| + <div class="feature-description"> |
| + <h3 class="i18n_firstRun_feature_tracking feature-title"></h3> |
| + <span class="i18n_firstRun_feature_tracking_description"></span> |
| + </div> |
| + <div id="toggle-tracking" class="toggle"> |
| + <div class="i18n_firstRun_toggle_on toggle-on"></div> |
| + <div class="toggle-blob"></div> |
| + <div class="i18n_firstRun_toggle_off toggle-off"></div> |
| + </div> |
| + </li> |
| + </ul> |
| + </div> |
| + |
| + <ul id="can-do-more-overview"> |
| + <li id="feature-first"> |
| + <img src="/skin/features/social.png"> |
|
Thomas Greiner
2013/07/15 17:37:01
Use background-image instead of image tags.
|
| + <h4 class="i18n_firstRun_feature_social"></h4> |
| + </li> |
| + <li> |
| + <img src="/skin/features/tracking.png"> |
|
Thomas Greiner
2013/07/15 17:37:01
Use background-image instead of image tags.
|
| + <h4 class="i18n_firstRun_feature_tracking"></h4> |
| + </li> |
| + <li> |
| + <img src="/skin/features/malware.png"> |
|
Thomas Greiner
2013/07/15 17:37:01
Use background-image instead of image tags.
|
| + <h4 class="i18n_firstRun_feature_malware"></h4> |
| + </li> |
| + </ul> |
| + <div class="clearfix"></div> |
| + |
| + <div id="activate-features" class="i18n_firstRun_feature_activate" status="overview"> |
|
Thomas Greiner
2013/07/15 17:37:01
This is not a standard attribute of DIV. Either us
|
| + </div> |
| + |
| + </section> |
| + |
| + |
| + <section id="share"> |
| + <div id="text"> |
| + <h2 class="i18n_firstRun_please"></h2> |
| + <a id="donate" href="" class="i18n_firstRun_donate" target="_blank"></a> |
|
Thomas Greiner
2013/07/15 17:37:01
Remove href="". If there is no URL associated with
|
| + <h2 class="i18n_firstRun_or_tell"></h2> |
| + </div> |
| + <div id="share-buttons"> |
| + <a id="share-facebook" href="https://www.facebook.com/adblockplus" target="_blank" > |
|
Thomas Greiner
2013/07/15 17:37:01
No need for changing this. Instead of putting the
|
| + <img src="/skin/social/facebook.png" alt="facebook" data-script="https://facebook.com/plugins/like.php?"> |
| + </a> |
| + <a id="share-twitter" href="https://twitter.com/adblockplus" target="_blank"> |
| + <img src="/skin/social/twitter.png" alt="twitter" data-script="https://platform.twitter.com/widgets.js"> |
| + </a> |
| + <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target="_blank"> |
| + <img src="/skin/social/googleplus.png" alt="googple plus" data-script="https://apis.google.com/js/plusone.js"> |
| + </a> |
| + </div> |
| + <div class="clearfix"></div> |
| + </section> |
| + |
| + <footer> |
|
Thomas Greiner
2013/07/15 17:37:01
Why does this still exist? If you don't want to us
|
| + <!-- <h1 class="i18n_firstRun_share"></h1> --> |
| + |
| + </footer> |
| + |
| + <div id="glass-pane"> |
| + <iframe id="share-popup" scrolling="no"></iframe> |
| + </div> |
| + </body> |
| +</html> |
« no previous file with comments
|
« no previous file
|
chrome/content/ui/firstRun.js » ('j')
|
chrome/content/ui/firstRun.js » ('J')
