First run page triggering

src/plugin/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
 
 #include "AdblockPlusClient.h"
@@ skipping 399 matching lines @@
     Communication::InputBuffer response = CallAdblockPlusEngineProcedure(request);
     std::vector<std::wstring> retValue = ReadStrings(response);
     return retValue.size() > 0 ? retValue.at(0) : L"";
   }
   catch (const std::exception& e)
   {
     DEBUG_GENERAL(e.what());
     return L"";
   }
 }
+
+bool CAdblockPlusClient::GetIsFirstRun()

[Wladimir Palant, 2013/07/11 11:58:10]

CAdblockPlusClient::IsFirstRun() should be a better name - you are querying a
flag here. Same applies to the call name, should be
Communication::PROC_IS_FIRST_RUN.

+{
+  Communication::OutputBuffer request;
+  request << Communication::PROC_GET_IS_FIRST_RUN;
+  try
+  {
+    Communication::InputBuffer response = CallAdblockPlusEngineProcedure(request);

[Wladimir Palant, 2013/07/11 11:58:10]

CallAdblockPlusEngineProcedure(Communication::PROC_GET_IS_FIRST_RUN) will do
here, no need to fill OutputBuffer explicitly here.

+    bool res = false;

[Wladimir Palant, 2013/07/11 11:58:10]

Please don't initialize that variable, its initial value is ignored and
overwritten one line below.

+    response >> res;
+    return res;
+  }
+  catch (const std::exception& e)
+  {
+    DEBUG_GENERAL(e.what());
+  }
+  return false;
+}