First run page triggering

src/engine/main.cpp

 #include <AdblockPlus.h>
 #include <functional>
 #include <vector>
 #include <Windows.h>
 
 #include "../shared/AutoHandle.h"
 #include "../shared/Communication.h"
 #include "../shared/Dictionary.h"
 #include "../shared/Utils.h"
 #include "../shared/Version.h"
+#include "../shared/CriticalSection.h"
 #include "Debug.h"
 #include "Updater.h"
 
 namespace
 {
   std::auto_ptr<AdblockPlus::FilterEngine> filterEngine;
 
   void WriteStrings(Communication::OutputBuffer& response,
       const std::vector<std::string>& strings)
   {
@@ skipping 10 matching lines @@
     response << count;
     for (int32_t i = 0; i < count; i++)
     {
       AdblockPlus::SubscriptionPtr subscription = subscriptions[i];
       response << subscription->GetProperty("url")->AsString()
                << subscription->GetProperty("title")->AsString()
                << subscription->GetProperty("specialization")->AsString()
                << subscription->IsListed();
     }
   }
+  
+  CriticalSection firstRunLock;
+  bool firstRunActionTaken = false;
 
   Communication::OutputBuffer HandleRequest(Communication::InputBuffer& request)
   {
     Communication::OutputBuffer response;
 
     Communication::ProcType procedure;
     request >> procedure;
     switch (procedure)
     {
       case Communication::PROC_MATCHES:
@@ skipping 109 matching lines @@
         AdblockPlus::JsValuePtr valuePtr = filterEngine->GetPref(name);
         if ((valuePtr->IsNull()) || (!valuePtr->IsString()))
           response << 0;
         else
         {
           response << 1;
           response << valuePtr->AsString();
         }
         break;
       }
-      case Communication::PROC_GET_IS_FIRST_RUN:
+      case Communication::PROC_IS_FIRST_RUN_ACTION_NEEDED:
+      {
+        CriticalSection::Lock lock(firstRunLock);
+        if (!firstRunActionTaken && filterEngine->IsFirstRun())
         {
-          response << filterEngine->IsFirstRun();
-          break;
+          response << !firstRunActionTaken;

[Wladimir Palant, 2013/07/21 11:53:45]

How about just response << true? No point obscuring the logic here...

+          firstRunActionTaken = true;
         }

[Wladimir Palant, 2013/07/21 11:53:45]

What about:

else
  response << false;

Shouldn't we always send a response?

+        break;
+      }
 
     }
     return response;
   }
 
   DWORD WINAPI ClientThread(LPVOID param)
   {
     std::auto_ptr<Communication::Pipe> pipe(static_cast<Communication::Pipe*>(param));
 
     try
@@ skipping 92 matching lines @@
     }
     catch (std::runtime_error e)
     {
       DebugException(e);
       return 1;
     }
   }
 
   return 0;
 }